fix: provide upper bound on jedi pin#9449
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses sandbox/LSP dependency resolution failures by adding an upper bound to the jedi dependency to avoid incompatibilities with python-lsp-server’s current jedi<0.20.0 requirement.
Changes:
- Constrain
jedito>=0.18.0,<0.20.0inpyproject.tomlto avoid resolver conflicts. - Update the inline comment to clarify the constraint is temporary and intended for dependency resolution.
Comment on lines
12
to
17
| dependencies = [ | ||
| # For maintainable cli | ||
| "click>=8.0,<9", | ||
| # code completion | ||
| "jedi>=0.18.0", | ||
| # code completion (upper bound applied temporarily for resolution) | ||
| "jedi>=0.18.0,<0.20.0", | ||
| # compile markdown to html |
Comment on lines
13
to
+16
| # For maintainable cli | ||
| "click>=8.0,<9", | ||
| # code completion | ||
| "jedi>=0.18.0", | ||
| # code completion (upper bound applied temporarily for resolution) | ||
| "jedi>=0.18.0,<0.20.0", |
mscolnick
approved these changes
May 4, 2026
Contributor
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.5-dev12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
closes #9446
closes #9447
Currently
jedi==0.20.0is incompatible withpython-lsp(jedi<0.20.0is hardcoded). As such, limitjedifor now, until we can properly solve