Skip to content

fix label alignment#9486

Merged
mscolnick merged 1 commit into
mainfrom
sham/fix-label-alignment
May 11, 2026
Merged

fix label alignment#9486
mscolnick merged 1 commit into
mainfrom
sham/fix-label-alignment

Conversation

@Light2Dark

@Light2Dark Light2Dark commented May 8, 2026

Copy link
Copy Markdown
Member

📝 Summary

Fixes #9481 . Doesn't break tables

image image

📋 Pre-Review Checklist

  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it.
  • Video or media evidence is provided for any visual changes (optional).

✅ Merge Checklist

  • I have read the contributor guidelines.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Tests have been added for the changes made.
Copilot AI review requested due to automatic review settings May 8, 2026 23:01
@vercel

vercel Bot commented May 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment May 8, 2026 11:03pm

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Architecture diagram
sequenceDiagram
    participant Render as Labeled Renderer
    participant DOM as Browser DOM
    participant CSS as Tailwind CSS

    Note over Render,CSS: Label alignment flow (PR fix for PR #9100 regression)

    Render->>DOM: Render `<div part="label" class="inline-flex items-center m-0 p-0">`
    DOM->>CSS: Apply `inline-flex` and `items-center` to label wrapper

    alt Inline (side) label mode (e.g., switch, checkbox, inline radio)
        CSS->>CSS: `inline-flex` makes wrapper shrink-wrap content
        CSS->>CSS: `items-center` vertically centers label text with control
        Note over Render,CSS: Fixes regression: label text now aligns vertically with control center
    else Top label mode (e.g., text, number, dropdown, code_editor)
        CSS->>CSS: `inline-flex` has no visible effect (block context from parent)
        CSS->>CSS: Label renders above control as before
    else Table label mode (flush table output)
        DOM->>DOM: Inherits `--marimo-table-edge-padding` via wrapper div
        CSS->>CSS: `inline-flex` + `items-center` correctly centers table label
    end

    Note over Render,CSS: Key property change: added `inline-flex` and `items-center`
Loading

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a UI regression where mo.ui.switch (and other side-labeled controls using Labeled) render their label text vertically misaligned relative to the control, and adds a dedicated smoke-test notebook for manual visual verification of label positioning across configurations.

Changes:

  • Update the Labeled component’s label wrapper to use inline-flex items-center to restore vertical centering for side-aligned labels.
  • Add a new labels.py smoke test notebook covering multiple label layouts (inline/side, top/full-width, markdown labels, tables) for manual regression checking.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
marimo/_smoke_tests/labels.py Adds a manual visual smoke test notebook exercising label alignment across a range of labeled UI components.
frontend/src/plugins/impl/common/labeled.tsx Adjusts the label wrapper’s layout classes to vertically center label content next to controls.
@Light2Dark Light2Dark added the bug Something isn't working label May 8, 2026
@mscolnick mscolnick mentioned this pull request May 11, 2026
1 task
@mscolnick mscolnick merged commit a235ee1 into main May 11, 2026
51 of 53 checks passed
@mscolnick mscolnick deleted the sham/fix-label-alignment branch May 11, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

3 participants