Skip to content

Sort toml entries when writing config#9686

Merged
dmadisetti merged 1 commit into
marimo-team:mainfrom
foxcroftjn:toml
May 26, 2026
Merged

Sort toml entries when writing config#9686
dmadisetti merged 1 commit into
marimo-team:mainfrom
foxcroftjn:toml

Conversation

@foxcroftjn

@foxcroftjn foxcroftjn commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📝 Summary

Closes #9682

📋 Pre-Review Checklist

  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it.
  • Video or media evidence is provided for any visual changes (optional).

✅ Merge Checklist

  • I have read the contributor guidelines.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Tests have been added for the changes made.
Copilot AI review requested due to automatic review settings May 26, 2026 03:35
@vercel

vercel Bot commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment May 26, 2026 3:36am

Request Review
@github-actions

github-actions Bot commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.
@foxcroftjn

foxcroftjn commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA.
Copilot AI reviewed May 26, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR aims to make saved TOML config output deterministic by sorting keys when writing the config file.

Changes:

  • Add sort_keys=True to the TOML serialization call during config save.
Comment thread marimo/_config/manager.py
@foxcroftjn

foxcroftjn commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

recheck
@dmadisetti dmadisetti added the enhancement New feature or request label May 26, 2026
dmadisetti
dmadisetti approved these changes May 26, 2026
View reviewed changes

@dmadisetti dmadisetti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@dmadisetti dmadisetti merged commit cb1f41b into marimo-team:main May 26, 2026
45 of 52 checks passed
@dmadisetti dmadisetti mentioned this pull request May 26, 2026
Merged
@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.9-dev7
dmadisetti added a commit that referenced this pull request May 28, 2026
@dmadisetti
test: add a test to check for ordered keys in toml serialization (#9690)
7af71c4 
## 📝 Summary

Fast follow to #9686 (deterministic toml serialization)

Adds a quick unit test as a sanity check for determinism. (Note this
only flakily fails without the change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

3 participants

@foxcroftjn @dmadisetti