feat(storage): search the backend when no loaded entries match by Light2Dark · Pull Request #9835 · marimo-team/marimo

Light2Dark · 2026-06-09T09:32:41Z

📝 Summary

Split out from #9708. Part of the work for #9662.

When a prefix query produces no matches among the already-loaded entries, this pages through the backend to surface remote results:

Entries are now matched by full path (not just basename), so partial path queries like folder/x resolve folder/xsomething. Because object stores evaluate prefixes on a path-segment basis, the parent directory is listed and filtered client-side.
When there are no loaded matches, the panel offers a "Search more entries" action (the button or pressing Enter) that pages through the backend up to 5 pages per trigger, stopping early on a match or when the listing is exhausted. If it reaches the cap without a match, it shows "Continue searching" to fetch the next batch. Status rows reflect the search state (searching / found / no matches / capped / error).

📋 Pre-Review Checklist

For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it.
Video or media evidence is provided for any visual changes (optional).

✅ Merge Checklist

I have read the contributor guidelines.
Documentation has been updated where applicable, including docstrings for API changes.
Tests have been added for the changes made.

vercel · 2026-06-09T09:32:52Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
marimo-docs	Ready	Preview, Comment	Jun 18, 2026 4:50am

cubic-dev-ai

1 issue found across 2 files

Architecture diagram

sequenceDiagram
    participant UI as Storage Panel
    participant Hooks as useStorage / useStoragePageFetcher
    participant State as Storage State (Zustand)
    participant Backend as Backend API (obstore)

    Note over UI,Backend: Search Flow with Remote Fallback

    UI->>UI: User types search query in filter input
    UI->>UI: filterEntries() checks loaded entries by full path + basename
    alt Has loaded matches
        UI->>UI: Display matching local entries
    else No loaded matches AND has directory prefix
        UI->>UI: remoteSearchPrefix() extracts parent directory
        UI->>Hooks: Trigger remote search via useStoragePageFetcher
        Hooks->>State: Request page for directory prefix
        State->>Backend: listObjects(prefix=directory)
        Backend-->>State: Page of entries + nextPageToken
        State-->>UI: Update entriesByPath with new entries
        UI->>UI: filterEntries() client-side on fetched entries
        alt Entries match query
            UI->>UI: Display matching remote entries
            UI->>UI: Set remoteSearch status to "found"
        else No entries yet AND nextPageToken exists
            UI->>UI: Show "Search more entries" button
            alt User clicks "Search more" (up to MAX_REMOTE_SEARCH_PAGES=5)
                UI->>Hooks: fetchNextPage()
                Hooks->>State: Request next page with token
                State->>Backend: listObjects(prefix, pageToken)
                Backend-->>State: Next page of entries
                State-->>UI: Update entriesByPath
                UI->>UI: Re-filter and loop
            else User presses Enter
                UI->>Hooks: fetchNextPage() (repeat until matched or exhausted)
            end
        end
    end

    Note over UI,Backend: Status/Error Handling

    alt Remote search exhausted
        UI->>UI: Set remoteSearch status to "exhausted"
        UI->>UI: Show "No results found" message
    else Remote search capped at 5 pages
        UI->>UI: Set remoteSearch status to "capped"
        UI->>UI: Show "Searched more entries" with retry option
    else Remote search error
        UI->>UI: Set remoteSearch status to "error"
        UI->>UI: Show error message with retry button
    end

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

When a prefix query has no matches among the loaded entries, page through the backend (up to a cap, or on Enter) to surface remote results, and match entries by full path so partial path queries work across object-store prefix boundaries. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Gate the "Search more entries" affordance on the same directory-prefix condition the action uses, so slashless queries (which remote search can't act on) no longer render a no-op button and Enter hint. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Gate the search-input Enter handler on namespaces.some(canContinueRemoteSearch) instead of hasSearch, so slashless queries (which can't trigger a backend search) no longer swallow CmdK's default Enter selection. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

kirangadhave

🚀 Looks good, just some nits

kirangadhave · 2026-06-18T04:55:11Z

+    searchPrefix === "" ? [] : (entriesByPath.get(searchKey) ?? []);
+  // The fetched page is the whole parent directory; we still need to filter
+  // it by the full search query before showing entries to the user.
+  const filteredRemoteEntries =


why not just call filterEntries? filtering on empty array should return empty anyways.

thanks! will address these in follow-up

kirangadhave · 2026-06-18T04:58:43Z

+        return false;
+      }
+
+      const canFetchPrefix =


We have a function canSearchMoreRemoteEntries which does the same check right?

kirangadhave · 2026-06-18T05:00:29Z

+    if (remoteSearch.status === "exhausted" && !hasLoadedMatches) {
+      return "No matches";
+    }
+    if (!hasSearch && !isPending && entries.length === 0 && !error) {


can combine with above as one predicate?

**This pull request was authored by a coding agent.** ## 📝 Summary Follow-up to #9835 — small cleanups from review feedback, no behavior change to the storage inspector beyond clearer tooltip copy. - Extract `hasUnfetchedPrefixPage`, shared by `canSearchMoreRemoteEntries` and `canContinueRemoteSearch`, removing the duplicated next-page check. - Drop the redundant length guard on `filteredRemoteEntries` (`filterEntries` already returns empty for an empty input). - Drop the redundant `!error` guard in the "No entries" status row (`statusRow` only renders when there is no error). - Clarify the search-input help tooltip: "Search by file name within loaded entries, or by prefix (e.g. `folder/x`) for backend search. Press Enter to fetch more results." ## 📋 Pre-Review Checklist  - [x] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [ ] Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it. - [x] Video or media evidence is provided for any visual changes (optional).  ## ✅ Merge Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] Documentation has been updated where applicable, including docstrings for API changes. - [ ] Tests have been added for the changes made.  <a href="https://cubic.dev/pr/marimo-team/marimo/pull/9920?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a>  --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

vercel Bot deployed to Preview June 9, 2026 09:35 View deployment

cubic-dev-ai Bot reviewed Jun 9, 2026

View reviewed changes

Comment thread frontend/src/components/storage/storage-inspector.tsx Outdated

Light2Dark force-pushed the Light2Dark/feat-storage-pagination branch 2 times, most recently from 167f472 to 0ca831a Compare June 15, 2026 03:33

Base automatically changed from Light2Dark/feat-storage-pagination to main June 15, 2026 15:12

github-actions Bot added the bash-focus Area to focus on during release bug bash label Jun 15, 2026

Light2Dark force-pushed the Light2Dark/feat-storage-remote-search branch from 3688ca0 to 5a36755 Compare June 15, 2026 15:25

Light2Dark added the enhancement New feature or request label Jun 15, 2026

vercel Bot deployed to Preview June 15, 2026 15:34 View deployment

Light2Dark marked this pull request as ready for review June 15, 2026 16:06

Copilot AI review requested due to automatic review settings June 15, 2026 16:06

Copilot AI reviewed Jun 15, 2026

Light2Dark requested review from Copilot and kirangadhave June 15, 2026 16:06

Copilot started reviewing on behalf of Light2Dark June 18, 2026 04:35 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

Comment thread frontend/src/components/storage/storage-inspector.tsx

Comment thread frontend/src/components/storage/storage-inspector.tsx

vercel Bot deployed to Preview June 18, 2026 04:50 View deployment

kirangadhave approved these changes Jun 18, 2026

View reviewed changes

Light2Dark merged commit 80d52cb into main Jun 18, 2026
31 checks passed

Light2Dark deleted the Light2Dark/feat-storage-remote-search branch June 18, 2026 05:15

Light2Dark mentioned this pull request Jun 18, 2026

refactor(storage): tidy remote-search helpers and tooltip copy #9920

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(storage): search the backend when no loaded entries match#9835

feat(storage): search the backend when no loaded entries match#9835
Light2Dark merged 3 commits into
mainfrom
Light2Dark/feat-storage-remote-search

Light2Dark commented Jun 9, 2026 •

edited

Loading

vercel Bot commented Jun 9, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Copilot AI left a comment

Copilot AI left a comment

Uh oh!

Uh oh!

kirangadhave left a comment

kirangadhave Jun 18, 2026

Light2Dark Jun 18, 2026

kirangadhave Jun 18, 2026

kirangadhave Jun 18, 2026

Uh oh!

Labels

3 participants

Uh oh!

Conversation

Light2Dark commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Summary

📋 Pre-Review Checklist

✅ Merge Checklist

vercel Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

kirangadhave left a comment

Choose a reason for hiding this comment

kirangadhave Jun 18, 2026

Choose a reason for hiding this comment

Light2Dark Jun 18, 2026

Choose a reason for hiding this comment

kirangadhave Jun 18, 2026

Choose a reason for hiding this comment

kirangadhave Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

Labels

3 participants

Light2Dark commented Jun 9, 2026 •

edited

Loading

vercel Bot commented Jun 9, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading