fix backticks in inline code (fixes #312) - #503
Conversation
|
Closing as having merge conflicts, stale, tagging with #983 |
|
I will add some tests even if it is pointless since whitespace is not checked when testing. |
|
I've added some commits to this branch but they don't show up here, is it because the PR is closed? |
|
Don't know. Stupid question time, just to confirm: You did push/sync? (That happened to me when I first realized you could push changes to a PR.) I can reopen, if you would like. I was going to do it without checking in, but didn't want to get in the way of you testing something based on the "stupid question". |
|
Quick search isn't showing me any documentation from GitHub that that block this feature if changes are made to PR that is closed....gotta start heading home. Let me know. |
|
Thing is, I don't see anywhere on this issue page the usual "add commits to branch to add changes to the PR" (something along those lines), so I guess this is not working as I expected but I can't see why. (yes, I pushed and the new commits showed up on my fork repo, but not here) Well, I'll open a new pr. I've also rebased so history looks more tidy. |
fix backticks in inline code (replaces markedjs#503, fixes markedjs#312)
2 participants
Fixes #312.
Some simple test cases are included in linked issue.