fix: support both bun.lock and bun.lockb for Bun detection#57
Closed
kuishou68 wants to merge 1 commit intomattpocock:mainfrom
Closed
fix: support both bun.lock and bun.lockb for Bun detection#57kuishou68 wants to merge 1 commit intomattpocock:mainfrom
kuishou68 wants to merge 1 commit intomattpocock:mainfrom
Conversation
…ttpocock#14) Bun v1.1.35+ uses bun.lock (text format) as the default lockfile, while older versions used bun.lockb (binary format). The skill should check for both to correctly detect Bun as the package manager in modern projects. Signed-off-by: cocoon <54054995+kuishou68@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
setup-pre-commitskill currently only checks forbun.lockbto detect Bun as the package manager. However, since Bun v1.1.35, the default lockfile format changed from the binarybun.lockbto the text-basedbun.lock.As a result, the skill will fail to identify Bun in modern projects that only have a
bun.lockfile.Fix
Update the package manager detection line to check for both
bun.lock(new, text format) andbun.lockb(old, binary format), so the skill works correctly regardless of which Bun version the project uses.Changes
setup-pre-commit/SKILL.md: Updated package manager detection to list bothbun.lockandbun.lockbas valid Bun lockfile namesCloses #14
Signed-off-by: cocoon 54054995+kuishou68@users.noreply.github.com