Skip to content

Conversation

@chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Jun 6, 2023

Description

I noticed that the information on the HTML/SVG decoding attribute was somewhat lacking. This PR adds a bit more information and description, to make it clearer what it actually does.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested a review from a team June 6, 2023 14:35
@chrisdavidmills chrisdavidmills requested review from a team as code owners June 6, 2023 14:35
@chrisdavidmills chrisdavidmills requested review from Ryuno-Ki, schalkneethling and wbamberg and removed request for a team June 6, 2023 14:35
@chrisdavidmills chrisdavidmills marked this pull request as draft June 6, 2023 14:35
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:SVG SVG docs Content:WebAPI Web API docs labels Jun 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Preview URLs (8 pages)
Flaws (2)

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/HTMLImageElement/decode
Title: HTMLImageElement: decode() method
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Element/error_event redirects to /en-US/docs/Web/API/HTMLElement/error_event

URL: /en-US/docs/Web/API/SVGImageElement
Title: SVGImageElement
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/SVGImageElement/href does not exist
External URLs (5)

URL: /en-US/docs/Web/SVG/Attribute/decoding
Title: decoding


URL: /en-US/docs/Web/HTML/Element/img
Title: <img>: The Image Embed element


URL: /en-US/docs/Web/API/HTMLImageElement/decode
Title: HTMLImageElement: decode() method


URL: /en-US/docs/Web/API/HTMLImageElement/decoding
Title: HTMLImageElement: decoding property


URL: /en-US/docs/Web/API/SVGImageElement/decode
Title: SVGImageElement: decode() method

(comment last updated: 2023-08-09 15:25:10)

@chrisdavidmills chrisdavidmills marked this pull request as ready for review June 7, 2023 10:24
Copy link
Contributor

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more suggestions, based on my latest testing that there is a measurable (even if difficult to directly observe with the human eye) blocking with sync on all three browsers.

Will also let you know when my post on this is published in case you want to reference it (likely later this week).

Co-authored-by: Barry Pollard <barrypollard@google.com>
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jul 5, 2023
chrisdavidmills and others added 5 commits July 5, 2023 10:55
@tunetheweb
Copy link
Contributor

LGTM! Thanks for updating, and for working through all the feedback. It bugged me for years that this attribute was so little understood. Hopefully between these updates and my recent blog post that you've linked here this will be better understood now.

@chrisdavidmills
Copy link
Contributor Author

LGTM! Thanks for updating, and for working through all the feedback. It bugged me for years that this attribute was so little understood. Hopefully between these updates and my recent blog post that you've linked here this will be better understood now.

Nice one @tunetheweb, I've enjoyed the collaboration on this one. It feels really good whenever you manage to fill in the blanks for a misunderstood web feature.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Aug 4, 2023
@chrisdavidmills chrisdavidmills enabled auto-merge (squash) August 4, 2023 15:20
Copy link
Collaborator

@Rumyra Rumyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one sentence I'm unsure of

Also are we linking here https://developer.mozilla.org/en-US/docs/Glossary/Jank where necessary?

@chrisdavidmills
Copy link
Contributor Author

Only one sentence I'm unsure of

Also are we linking here https://developer.mozilla.org/en-US/docs/Glossary/Jank where necessary?

Thanks @Rumyra! Weird sentence fixed, and jank links added.

@Rumyra Rumyra merged commit 5983875 into mdn:main Aug 10, 2023
@Rumyra
Copy link
Collaborator

Rumyra commented Aug 10, 2023

Awesome - thanks @chrisdavidmills

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:HTML Hypertext Markup Language docs Content:SVG SVG docs Content:WebAPI Web API docs

3 participants