fix(css): correct attr() restriction in url-taking functions#44589
Merged
Conversation
Contributor
|
Preview URLs (1 page) Flaws (3) Found an unexpected or unresolvable flaw? Please report it here. URL:
External URLs (1)URL:
(comment last updated: 2026-06-29 02:52:00) |
hamishwillee
approved these changes
Jun 29, 2026
Collaborator
There was a problem hiding this comment.
Thanks @samson1299
This was good. Note again though, you took an issue that is not triaged according to its label - it could have been incorrect. If you're going to take such an issue it would be good to explain why you trust it.
I've subedited a little. What you did was certainly acceptable - I wanted to make sure we mentioned the tainting first.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44030
The current docs incorrectly state that
attr()can work insideimage-set().Per the CSS Values 5 spec (attr-taint),
attr()is forbidden in any functionthat could produce a
<url>, includingimage-set()andimage().