FF154 No-Vary-Search updates - #45423
Open
hamishwillee wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
Content:HTTP
hamishwillee
commented
Sep 1, 2026
| No-Vary-Search: params=("param1" "param2") | ||
| No-Vary-Search: params, except=("param1" "param2") | ||
| No-Vary-Search: key-order, params, except=("param1") | ||
| No-Vary-Search: key-order, params, except=("param1" "param2") |
Collaborator
Author
There was a problem hiding this comment.
Without at least two values the order doesn't matter, because only the values that affect the response are relevant, and if you have one value, order doesn't matter.
8 tasks
Contributor
|
Preview URLs (1 page) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the
No-Vary-Searchdocs a little.I wanted to fix a few tenses such as " Indicates that URLs will not be cached" . The message is sent by the server, so its an instruction to not cache, not an indication of somethign that will happen (it might not).
Its also better to present this in terms of what is going on with the response.
Related dcocs work can be tracked in #45298