Use // comments for .json#3388
Merged
JoeKar merged 2 commits intomicro-editor:masterfrom Jul 30, 2024
injust:patch-1
Merged
Conversation
|
Thanks, hoping this gets merged soon |
Member
|
From my perspective it's good to chain the default from |
JoeKar
approved these changes
Jul 30, 2024
dmaluka
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comments to
.jsonfiles using//instead of the default#.Even though JSON does not support comments, JSON5 and JSONC exist, so
//is a much more sane default. It also improves the experience of editing micro's own config files.