Conversation
The `tokens` option implicitly enables `parts`, but did not enable full-pattern scanning. This caused scanning to stop at the first glob and merge the remaining path segments into the final token. Include `tokens` in `scanToEnd` and add regression coverage for #62.
Code Coverage OverviewLanguages: JavaScript JavaScript / code-coverage/nycThe overall line coverage in commit 5f5819d in the Show a line coverage summary of the most covered files.
|
mrmlnc
marked this pull request as ready for review
August 23, 2026 19:27
Member
|
Thanks for the PR @mrmlnc, I'll get this and the related one merged and published as a patch version soon. |
Closed
mergify Bot
added a commit
to ArcadeData/arcadedb
that referenced
this pull request
Aug 30, 2026
…in /studio [skip ci] Bumps [picomatch](https://github.com/micromatch/picomatch) from 4.0.5 to 4.0.7. Release notes *Sourced from [picomatch's releases](https://github.com/micromatch/picomatch/releases).* > 4.0.7 > ----- > > What's Changed > -------------- > > * fix: handle terminal globstars in parenthesized patterns by [`@mrmlnc`](https://github.com/mrmlnc) in [micromatch/picomatch#198](https://redirect.github.com/micromatch/picomatch/pull/198) > > **Full Changelog**: <micromatch/picomatch@4.0.6...4.0.7> > > 4.0.6 > ----- > > What's Changed > -------------- > > * fix: scan full pattern when tokens are requested by [`@mrmlnc`](https://github.com/mrmlnc) in [micromatch/picomatch#197](https://redirect.github.com/micromatch/picomatch/pull/197) > * fix: return complete pattern parts from scan by [`@mrmlnc`](https://github.com/mrmlnc) in [micromatch/picomatch#199](https://redirect.github.com/micromatch/picomatch/pull/199) > > **Full Changelog**: <micromatch/picomatch@4.0.5...4.0.6> Changelog *Sourced from [picomatch's changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md).* > 4.0.7 (2026-08-24) > ------------------ > > ### Fixed > > * Fixed terminal globstars in parenthesized patterns ([#142](https://redirect.github.com/micromatch/picomatch/issues/142), [e279bd7](micromatch/picomatch@e279bd7)). > > 4.0.6 (2026-08-24) > ------------------ > > ### Fixed > > * `scan()` now scans the full pattern when tokens are requested, instead of merging the remaining path segments into the final token ([#62](https://redirect.github.com/micromatch/picomatch/issues/62), [5f5819d](micromatch/picomatch@5f5819d)). > * `scan()` now returns complete pattern parts, including leading and trailing empty segments, and handles nested and escaped parentheses correctly ([#58](https://redirect.github.com/micromatch/picomatch/issues/58), [f201165](micromatch/picomatch@f201165)). Commits * [`6bb4067`](micromatch/picomatch@6bb4067) 4.0.7 * [`fdfb155`](micromatch/picomatch@fdfb155) Merge pull request [#198](https://redirect.github.com/micromatch/picomatch/issues/198) from micromatch/issue-142 * [`38c6b7a`](micromatch/picomatch@38c6b7a) 4.0.6 * [`ada9d3f`](micromatch/picomatch@ada9d3f) Merge pull request [#199](https://redirect.github.com/micromatch/picomatch/issues/199) from micromatch/issue-58 * [`9b74f6f`](micromatch/picomatch@9b74f6f) Merge pull request [#197](https://redirect.github.com/micromatch/picomatch/issues/197) from micromatch/issue-62 * [`f201165`](micromatch/picomatch@f201165) fix: return complete pattern parts from scan * [`e279bd7`](micromatch/picomatch@e279bd7) fix: handle terminal globstars in parenthesized patterns * [`5f5819d`](micromatch/picomatch@5f5819d) fix: scan full pattern when tokens are requested * See full diff in [compare view](micromatch/picomatch@4.0.5...4.0.7) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62.
The
tokensoption is documented to automatically enableparts.However,
scan()stopped at the first glob unlesspartsorscanToEndwas explicitly enabled.For example,
a/b/*/cproduced:{ parts: true }→['a', 'b', '*', 'c']{ tokens: true }→['a', 'b', '*/c']This change makes
tokensenable full-pattern scanning, producingconsistent parts and tokens. A regression test covering the original
issue has also been added..