Skip to content

Remove unused LXSS_DISTRO_FLAGS_WSLCORE_MODE#13603

Merged
OneBlue merged 1 commit into
masterfrom
user/oneblue/cleanup-7
Oct 16, 2025
Merged

Remove unused LXSS_DISTRO_FLAGS_WSLCORE_MODE#13603
OneBlue merged 1 commit into
masterfrom
user/oneblue/cleanup-7

Conversation

@OneBlue

@OneBlue OneBlue commented Oct 16, 2025

Copy link
Copy Markdown
Collaborator

Summary of the Pull Request

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unused LXSS_DISTRO_FLAGS_WSLCORE_MODE flag and its associated code path from the WSL service. The flag was previously defined but no longer serves a purpose in the codebase.

Key Changes

  • Removed LXSS_DISTRO_FLAGS_WSLCORE_MODE constant definition
  • Updated LXSS_DISTRO_FLAGS_ALL to exclude the removed flag
  • Removed the early return logic in WslCoreInstance::Initialize() that checked for this flag

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/windows/service/inc/wslservice.idl Removed flag definition and updated aggregate flag constant
src/windows/service/exe/WslCoreInstance.cpp Removed conditional early return that checked for the unused flag
@OneBlue OneBlue merged commit 0974c30 into master Oct 16, 2025
6 checks passed
@benhillis benhillis deleted the user/oneblue/cleanup-7 branch April 23, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants