Skip to content

CI: update issue for wslsettings being rebuilt and signature being overwritten#13855

Merged
benhillis merged 4 commits into
masterfrom
user/benhill/wslsettings_signing
Dec 11, 2025
Merged

CI: update issue for wslsettings being rebuilt and signature being overwritten#13855
benhillis merged 4 commits into
masterfrom
user/benhill/wslsettings_signing

Conversation

@benhillis

@benhillis benhillis commented Dec 8, 2025

Copy link
Copy Markdown
Member

This should prevent cmake from rebuilding the wslsettings project and overwriting the signature files.
@benhillis benhillis requested a review from a team as a code owner December 8, 2025 22:53

This comment was marked as outdated.

Sign in to view

@benhillis benhillis force-pushed the user/benhill/wslsettings_signing branch 2 times, most recently from 7264daf to 853f1fe Compare December 8, 2025 23:45
@benhillis benhillis requested a review from Copilot December 8, 2025 23:46
Copilot AI reviewed Dec 8, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Comment thread .pipelines/build-stage.yml Outdated
Comment thread .pipelines/build-stage.yml Outdated
@benhillis benhillis force-pushed the user/benhill/wslsettings_signing branch from 853f1fe to b1bd954 Compare December 8, 2025 23:53
@benhillis benhillis requested a review from Copilot December 8, 2025 23:53
@benhillis benhillis changed the title CI: update issue for wslsettings being rebuilt and signature being ov… Dec 8, 2025
Copilot AI reviewed Dec 8, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comment thread .pipelines/build-stage.yml Outdated
@benhillis

benhillis commented Dec 9, 2025

Copy link
Copy Markdown
Member Author

@OneBlue - unfortunately this didn't seem to work.
@benhillis benhillis requested a review from Copilot December 9, 2025 17:13
Copilot AI reviewed Dec 9, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
@benhillis benhillis force-pushed the user/benhill/wslsettings_signing branch from b8e2b80 to 5435d18 Compare December 10, 2025 19:31
@benhillis benhillis requested a review from Copilot December 10, 2025 19:31
Copilot AI reviewed Dec 10, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comment thread msipackage/CMakeLists.txt
OneBlue
OneBlue reviewed Dec 10, 2025
View reviewed changes
Comment thread msipackage/CMakeLists.txt Outdated
Comment thread msipackage/package.wix.in
@benhillis benhillis merged commit 5acd600 into master Dec 11, 2025
6 checks passed
@benhillis benhillis deleted the user/benhill/wslsettings_signing branch April 23, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@benhillis @OneBlue