Add Clang requirement to vswhere usage#14187
Merged
Merged
Conversation
JohnMcPMS
requested review from
Brian-Perkins,
OneBlue,
benhillis,
Copilot and
craigloewen-msft
OneBlue
approved these changes
Feb 9, 2026
OneBlue
left a comment
OneBlue
left a comment
Collaborator
There was a problem hiding this comment.
Nice, thank you for doing this !
benhillis
approved these changes
Feb 9, 2026
This was referenced Feb 12, 2026
benhillis
added a commit
that referenced
this pull request
Feb 13, 2026
* Move from shipping the initrd to generating it during install. (#14119) * Move from shipping the initrd to generating during package install. * pr feedback * working * adjust custom action conditions * update initrd test to cover more cases * Update msipackage/package.wix.in Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * use stack buffer * move initrd helper to filesystem.cpp and add unit test --------- Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Minor follow-up initrd feedback items (#14186) Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com> * Add Clang requirement to vswhere usage (#14187) * Enable detection cmake script for Visual Studio 2026 and pre-release versions of Visual Studio (#14160) * Updating to support VS2026 and insiders builds * Updated max ver (exclusive) to 19.0 * Fix command for vswhere to include prerelease --------- Co-authored-by: Ben Hillis <benhillis@gmail.com> * Update DistributionInfo.json due release of Ubuntu-24.04.4 (#14202) * Update Microsoft.WSL.DeviceHost with virtiofs and virtio networking (#14198) improvements. Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com> * virtioproxy: update setting of m_networkSettings to under the lock (#14210) Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com> * update HcsVirtualMachine with new VirtioNetworking behavior --------- Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: JohnMcPMS <johnmcp@microsoft.com> Co-authored-by: Andy Sterland <andster@microsoft.com> Co-authored-by: Carlos Nihelton <carlos.santanadeoliveira@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Add a requirement that the VS product have Clang installed when detecting with vswhere.
PR Checklist
Detailed Description of the Pull Request / Additional comments
If multiple products in the version range are installed, the invocation of vswhere will output multiple lines with each install path, breaking the rest of the cmake setup. This change adds a requirement that the product have Clang, which is what the later
if (NOT EXISTS ${LLVM_INSTALL_DIR})is testing for (although even that check is incorrect as this directory can exist without actually containing clang.exe due to alternate components).Also adds the
LLVM_INSTALL_DIRthat does not exist to the error message, making it easier to see why it was unhappy.Validation Steps Performed
Was able to build with both VS 2022 Enterprise and the VS Build tools products installed.