Fix potential init crash by catching exceptions in scope_exit reset()#40691
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Linux-side wil::details::lambda_call (scope-exit helper) to prevent exceptions thrown by the cleanup lambda from escaping reset() noexcept, which could otherwise terminate the process (notably impacting init).
Changes:
- Wraps
scope_exitlambda execution inlambda_call::reset()with exception handling. - Attempts to log caught exceptions during scope-exit execution.
dkbennett
approved these changes
Jun 2, 2026
benhillis
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This catches exceptions thrown from scope_exit. Because reset() is marked noexcept, an exception thrown from there could crash init.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed