Skip to content

Rename VirtioProxy networking mode to Consomme#40873

Merged
benhillis merged 2 commits into
masterfrom
user/benhill/consomme-networking-rename
Jun 23, 2026
Merged

Rename VirtioProxy networking mode to Consomme#40873
benhillis merged 2 commits into
masterfrom
user/benhill/consomme-networking-rename

Conversation

@benhillis

Copy link
Copy Markdown
Member

Renames the VirtioProxy networking mode to Consomme (after OpenVMM's consomme user-mode NAT), including the VirtioNetworking engine class/files. The .wslconfig networkingMode parser still accepts the legacy virtioproxy string as an alias.

Rename the VirtioProxy networking mode to Consomme across the C++/IDL/Linux
symbols and the networking engine class/files (VirtioNetworking ->
ConsommeNetworking). The .wslconfig networkingMode parser still accepts the
legacy "virtioproxy" string as an alias. Adds a docs section linking to
OpenVMM's consomme project, where the name comes from.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 22, 2026 23:55
@benhillis benhillis requested a review from a team as a code owner June 22, 2026 23:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames WSL/WSLC’s VirtioProxy networking mode to Consomme across the Windows service, WSLC session/SDK layers, Linux mini_init consumers, settings/UI surfaces, tests, and documentation. It also keeps backward compatibility for .wslconfig by accepting the legacy VirtioProxy/virtioproxy value as an alias for Consomme.

Changes:

  • Renames the networking mode enum value to Consomme (value remains 4) and updates the corresponding Windows/Linux plumbing and info output.
  • Renames the virtio-net networking engine implementation to ConsommeNetworking and updates initialization/configuration/port-mapping call paths.
  • Updates test coverage, policy expectations, user-facing strings, Intune templates, and technical documentation to reflect the new name.

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
test/windows/WSLCTests.cpp Updates WSLC e2e tests to use WSLCNetworkingModeConsomme and renames test methods accordingly.
test/windows/wslc/WSLCCLISettingsUnitTests.cpp Updates CLI/settings unit tests to expect Consomme as the default networking mode.
test/windows/UnitTests.cpp Updates .wslconfig invalid-value warning text and networking-mode mapping expectations.
test/windows/PolicyTests.cpp Updates policy-driven networking mode tests from VirtioProxy to Consomme (including wslinfo output checks).
test/windows/PluginTests.cpp Updates plugin tests to create WSLC sessions using Consomme mode.
test/windows/NetworkTests.cpp Renames the VirtioProxy test suite to Consomme and updates mode selection in the networking tests.
src/windows/wslsettings/LibWsl.cs Renames the C# NetworkingConfiguration enum member to Consomme.
src/windows/wslcsession/WSLCVirtualMachine.cpp Switches session-side networking behavior checks to WSLCNetworkingModeConsomme.
src/windows/WslcSDK/wslcsdk.cpp Updates WSLC SDK default runtime networking mode to Consomme.
src/windows/service/inc/WSLCShared.idl Renames the WSLC networking mode enum value and updates related flag comments.
src/windows/service/exe/WslCoreVm.cpp Updates service VM initialization to include/instantiate the ConsommeNetworking engine and related flags.
src/windows/service/exe/HcsVirtualMachine.cpp Updates container VM engine creation and port-mapping dispatch to use ConsommeNetworking.
src/windows/libwsl/WslCoreConfigInterface.cpp Updates enum consistency static_asserts for Consomme.
src/windows/inc/WslCoreConfigInterface.h Renames the exported NetworkingConfiguration enum member to Consomme.
src/windows/common/WSLCUserSettings.h Updates WSLC settings default networking mode to Consomme.
src/windows/common/WSLCUserSettings.cpp Updates WSLC settings parsing to recognize consomme as the networking mode value.
src/windows/common/WslCoreConfig.h Renames the .wslconfig enum to Consomme and adds a legacy VirtioProxy alias in the mapping table.
src/windows/common/WslCoreConfig.cpp Updates config normalization/validation paths and warnings to use Consomme semantics.
src/windows/common/ConsommeNetworking.h Introduces renamed networking engine class/flags for Consomme.
src/windows/common/ConsommeNetworking.cpp Implements Consomme engine behavior (guest configuration, DNS, port tracking, notifications) under the new name.
src/windows/common/CMakeLists.txt Updates the build to compile/link ConsommeNetworking.* instead of VirtioNetworking.*.
src/shared/inc/lxinitshared.h Renames the mini_init networking mode constant to LxMiniInitNetworkingModeConsomme (value 4).
src/linux/init/wslinfo.cpp Updates wslinfo --networking-mode output to print consomme.
src/linux/init/util.cpp Updates networking mode validation range to the renamed Consomme enum constant.
src/linux/init/localhost.cpp Updates networking mode validation range to the renamed Consomme enum constant.
localization/strings/en-US/Resources.resw Renames/updates the user-facing message for “requires virtio” to Consomme wording.
intune/en-US/WSL.adml Updates the displayed networking mode string from VirtioProxy to Consomme in policy resources.
doc/docs/technical-documentation/localhost.md Adds Consomme-mode documentation and references the Consomme engine implementation.
Comments suppressed due to low confidence (1)

src/windows/common/ConsommeNetworking.h:34

  • Other INetworkingEngine implementations in this repo (e.g. NatNetworking, BridgedNetworking) mark the destructor override, which helps catch signature mismatches during refactors. ConsommeNetworking should follow the same pattern.
Comment thread src/windows/common/WSLCUserSettings.cpp
Comment thread src/windows/service/exe/WslCoreVm.cpp Outdated
Comment thread src/windows/service/exe/WslCoreVm.cpp Outdated
Comment thread src/windows/wslcsession/WSLCVirtualMachine.cpp Outdated
Comment thread test/windows/WSLCTests.cpp
Comment thread test/windows/NetworkTests.cpp Outdated
Comment thread src/windows/service/exe/HcsVirtualMachine.cpp Outdated
Comment thread src/windows/service/exe/HcsVirtualMachine.cpp Outdated
Comment thread localization/strings/en-US/Resources.resw Outdated
Comment thread doc/docs/technical-documentation/localhost.md Outdated
OneBlue
OneBlue previously approved these changes Jun 23, 2026

@OneBlue OneBlue left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment

…ked string

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@benhillis benhillis enabled auto-merge (squash) June 23, 2026 00:49
@benhillis benhillis merged commit b9e1d70 into master Jun 23, 2026
11 checks passed
@benhillis benhillis deleted the user/benhill/consomme-networking-rename branch June 23, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants