Rename VirtioProxy networking mode to Consomme#40873
Merged
Merged
Conversation
Rename the VirtioProxy networking mode to Consomme across the C++/IDL/Linux symbols and the networking engine class/files (VirtioNetworking -> ConsommeNetworking). The .wslconfig networkingMode parser still accepts the legacy "virtioproxy" string as an alias. Adds a docs section linking to OpenVMM's consomme project, where the name comes from. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames WSL/WSLC’s VirtioProxy networking mode to Consomme across the Windows service, WSLC session/SDK layers, Linux mini_init consumers, settings/UI surfaces, tests, and documentation. It also keeps backward compatibility for .wslconfig by accepting the legacy VirtioProxy/virtioproxy value as an alias for Consomme.
Changes:
- Renames the networking mode enum value to
Consomme(value remains4) and updates the corresponding Windows/Linux plumbing and info output. - Renames the virtio-net networking engine implementation to
ConsommeNetworkingand updates initialization/configuration/port-mapping call paths. - Updates test coverage, policy expectations, user-facing strings, Intune templates, and technical documentation to reflect the new name.
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| test/windows/WSLCTests.cpp | Updates WSLC e2e tests to use WSLCNetworkingModeConsomme and renames test methods accordingly. |
| test/windows/wslc/WSLCCLISettingsUnitTests.cpp | Updates CLI/settings unit tests to expect Consomme as the default networking mode. |
| test/windows/UnitTests.cpp | Updates .wslconfig invalid-value warning text and networking-mode mapping expectations. |
| test/windows/PolicyTests.cpp | Updates policy-driven networking mode tests from VirtioProxy to Consomme (including wslinfo output checks). |
| test/windows/PluginTests.cpp | Updates plugin tests to create WSLC sessions using Consomme mode. |
| test/windows/NetworkTests.cpp | Renames the VirtioProxy test suite to Consomme and updates mode selection in the networking tests. |
| src/windows/wslsettings/LibWsl.cs | Renames the C# NetworkingConfiguration enum member to Consomme. |
| src/windows/wslcsession/WSLCVirtualMachine.cpp | Switches session-side networking behavior checks to WSLCNetworkingModeConsomme. |
| src/windows/WslcSDK/wslcsdk.cpp | Updates WSLC SDK default runtime networking mode to Consomme. |
| src/windows/service/inc/WSLCShared.idl | Renames the WSLC networking mode enum value and updates related flag comments. |
| src/windows/service/exe/WslCoreVm.cpp | Updates service VM initialization to include/instantiate the ConsommeNetworking engine and related flags. |
| src/windows/service/exe/HcsVirtualMachine.cpp | Updates container VM engine creation and port-mapping dispatch to use ConsommeNetworking. |
| src/windows/libwsl/WslCoreConfigInterface.cpp | Updates enum consistency static_asserts for Consomme. |
| src/windows/inc/WslCoreConfigInterface.h | Renames the exported NetworkingConfiguration enum member to Consomme. |
| src/windows/common/WSLCUserSettings.h | Updates WSLC settings default networking mode to Consomme. |
| src/windows/common/WSLCUserSettings.cpp | Updates WSLC settings parsing to recognize consomme as the networking mode value. |
| src/windows/common/WslCoreConfig.h | Renames the .wslconfig enum to Consomme and adds a legacy VirtioProxy alias in the mapping table. |
| src/windows/common/WslCoreConfig.cpp | Updates config normalization/validation paths and warnings to use Consomme semantics. |
| src/windows/common/ConsommeNetworking.h | Introduces renamed networking engine class/flags for Consomme. |
| src/windows/common/ConsommeNetworking.cpp | Implements Consomme engine behavior (guest configuration, DNS, port tracking, notifications) under the new name. |
| src/windows/common/CMakeLists.txt | Updates the build to compile/link ConsommeNetworking.* instead of VirtioNetworking.*. |
| src/shared/inc/lxinitshared.h | Renames the mini_init networking mode constant to LxMiniInitNetworkingModeConsomme (value 4). |
| src/linux/init/wslinfo.cpp | Updates wslinfo --networking-mode output to print consomme. |
| src/linux/init/util.cpp | Updates networking mode validation range to the renamed Consomme enum constant. |
| src/linux/init/localhost.cpp | Updates networking mode validation range to the renamed Consomme enum constant. |
| localization/strings/en-US/Resources.resw | Renames/updates the user-facing message for “requires virtio” to Consomme wording. |
| intune/en-US/WSL.adml | Updates the displayed networking mode string from VirtioProxy to Consomme in policy resources. |
| doc/docs/technical-documentation/localhost.md | Adds Consomme-mode documentation and references the Consomme engine implementation. |
Comments suppressed due to low confidence (1)
src/windows/common/ConsommeNetworking.h:34
- Other INetworkingEngine implementations in this repo (e.g. NatNetworking, BridgedNetworking) mark the destructor
override, which helps catch signature mismatches during refactors. ConsommeNetworking should follow the same pattern.
OneBlue
previously approved these changes
Jun 23, 2026
OneBlue
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. One minor comment
…ked string Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
OneBlue
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
VirtioProxynetworking mode toConsomme(after OpenVMM's consomme user-mode NAT), including theVirtioNetworkingengine class/files. The.wslconfignetworkingModeparser still accepts the legacyvirtioproxystring as an alias.