Skip to content

Don't hard-fail the distro validation script when a download fails - #40914

Merged
Blue (OneBlue) merged 2 commits into
masterfrom
user/oneblue/download-error
Jun 25, 2026
Merged

Don't hard-fail the distro validation script when a download fails#40914
Blue (OneBlue) merged 2 commits into
masterfrom
user/oneblue/download-error

Conversation

@OneBlue

Copy link
Copy Markdown
Collaborator

Summary of the Pull Request

This change updates the distro validation script not to fail immediately if a download fails. This makes it easier to identify when multiple distros fail to download

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@OneBlue
Blue (OneBlue) requested a review from a team as a code owner June 25, 2026 20:47
Copilot AI review requested due to automatic review settings June 25, 2026 20:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the modern distribution validation script to continue validation when a downloaded .wsl payload can’t be parsed as a tar, so the script can report multiple failures in one run.

Changes:

  • Wrap read_tar(...) for HTTP(S) downloads in a try/except to avoid aborting the whole script on tar read failures.
  • Emit an error(...) entry when tar parsing fails instead of letting the exception unwind.
Comment thread distributions/validate-modern.py Outdated
@OneBlue
Blue (OneBlue) merged commit 9c88216 into master Jun 25, 2026
13 checks passed
@OneBlue
Blue (OneBlue) deleted the user/oneblue/download-error branch June 25, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants