Skip to content

Log an error when connect() fails in the NAT mode relay - #41033

Merged
Blue (OneBlue) merged 1 commit into
masterfrom
user/oneblue/connect-log
Jul 9, 2026
Merged

Blue (OneBlue) merged 1 commit into
masterfrom
user/oneblue/connect-log

Conversation

@OneBlue

Copy link
Copy Markdown
Collaborator

Summary of the Pull Request

We've seen a couple test failure where the NAT relay fails to connect. This change adds logging with more information to help us root cause this issue.

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@OneBlue
Blue (OneBlue) requested a review from a team as a code owner July 8, 2026 18:45
Copilot AI review requested due to automatic review settings July 8, 2026 18:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds diagnostic logging to the Linux-side localhost/NAT relay path to capture additional context when a TCP connect() attempt fails, helping root-cause intermittent test failures where the relay cannot connect to the requested loopback port.

Changes:

  • Log an explicit error when connect() fails while establishing the relay TCP connection.
  • Include the requested port, socket family, and errno in the log message for troubleshooting.
@OneBlue
Blue (OneBlue) merged commit e47489e into master Jul 9, 2026
12 checks passed
@OneBlue
Blue (OneBlue) deleted the user/oneblue/connect-log branch July 9, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants