Fix unqualified WEX::Logging::Log breaking release builds - #41315
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a release-build compilation break in the Windows installer test suite by fully qualifying the Log symbol used under WSL_OFFICIAL_BUILD.
Changes:
- Replaces an unqualified
Log::Comment(...)call withWEX::Logging::Log::Comment(...)inside theWSL_OFFICIAL_BUILDguard inInstallerTests.cpp.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ben Hillis (benhillis)
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change solves an unqualified use a
WEX::Logging::Log, which breaks release builds (under a WSL_OFFICIAL_BUILD ifdef)PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed