Skip to content

Fix unqualified WEX::Logging::Log breaking release builds - #41315

Merged
Ben Hillis (benhillis) merged 1 commit into
masterfrom
user/oneblue/fix-release-build
Aug 11, 2026
Merged

Fix unqualified WEX::Logging::Log breaking release builds#41315
Ben Hillis (benhillis) merged 1 commit into
masterfrom
user/oneblue/fix-release-build

Conversation

@OneBlue

Copy link
Copy Markdown
Collaborator

Summary of the Pull Request

This change solves an unqualified use a WEX::Logging::Log, which breaks release builds (under a WSL_OFFICIAL_BUILD ifdef)

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@OneBlue
Blue (OneBlue) requested a review from a team as a code owner August 11, 2026 19:29
Copilot AI lite review requested due to automatic review settings August 11, 2026 19:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a release-build compilation break in the Windows installer test suite by fully qualifying the Log symbol used under WSL_OFFICIAL_BUILD.

Changes:

  • Replaces an unqualified Log::Comment(...) call with WEX::Logging::Log::Comment(...) inside the WSL_OFFICIAL_BUILD guard in InstallerTests.cpp.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@benhillis
Ben Hillis (benhillis) enabled auto-merge (squash) August 11, 2026 21:12
@benhillis
Ben Hillis (benhillis) merged commit ed4bfcc into master Aug 11, 2026
12 checks passed
@benhillis
Ben Hillis (benhillis) deleted the user/oneblue/fix-release-build branch August 11, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants