Poll for the result of operations during MSI installation - #41415
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates MSI custom action logic to poll AppX operations safely, avoiding delegate lifetime issues during DLL unloading.
Changes:
- Adds polling-based operation waiting and cleanup.
- Handles error and canceled states.
- Updates deprovisioning and error paths.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ben Hillis (benhillis)
approved these changes
Aug 21, 2026
Ben Hillis (benhillis)
left a comment
Member
There was a problem hiding this comment.
This definitely seems like a cpp / winrt bug, hopefully we can get a fix or better guidance from them.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change updates the custom action logic to poll for the completion of appx operations during the MSI installations.
Calling
.get()registers a delegate that, due to a cppwinrt lifetime issue, might not get released untilwslinstall.dllis unloaded, causing a crash since the release will jump into unloaded code.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed