WindowsML cpp-abi: enable Control Flow Guard to fix BinSkim BA2008 - #655
Merged
Merged
Conversation
CppAbiEPEnumerationSample failed BinSkim BA2008 (Enable Control Flow Guard) because the cpp-abi folder had no Directory.Build.props, so MSBuild's nearest-ancestor auto-import resolved to WindowsML/Directory.Build.props (platform/OutDir only, no CFG) and never reached the CFG-enabling settings. Add cpp-abi/Directory.Build.props mirroring WindowsML/cpp/Directory.Build.props: import the parent props and set ControlFlowGuard=Guard, /dynamicbase, /Qspectre, and CETCompat (non-ARM64). Related: AB#60433419.
Scott Jones (Scottj1s)
approved these changes
Jul 17, 2026
shisan (qiutongMS)
pushed a commit
that referenced
this pull request
Aug 25, 2026
Port main PR #655's complete CFG and SDL configuration while retaining the release Central Package Management project. Exclude main's generated packages.config imports and record the source and validation in the reconciliation docs and matrix. Source-commit: f5ec17b Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CppAbiEPEnumerationSample failed BinSkim BA2008 (Enable Control Flow Guard) because the cpp-abi folder had no Directory.Build.props, so MSBuild's nearest-ancestor auto-import resolved to WindowsML/Directory.Build.props (platform/OutDir only, no CFG) and never reached the CFG-enabling settings. Add cpp-abi/Directory.Build.props mirroring WindowsML/cpp/Directory.Build.props: import the parent props and set ControlFlowGuard=Guard, /dynamicbase, /Qspectre, and CETCompat (non-ARM64). Related: AB#60433419.
Description
Please include a summary of the change and/or which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Target Release
Please specify which release this PR should align with. e.g., 1.0, 1.1, 1.1 Preview 1.
Checklist
Note that /azp run currently isn't working for this repo.