Skip to content

[contributing.md] use correct path separator in linux commands#16591

Open
mikeharder wants to merge 1 commit intomicrosoft:mainfrom
mikeharder:patch-1
Open

[contributing.md] use correct path separator in linux commands#16591
mikeharder wants to merge 1 commit intomicrosoft:mainfrom
mikeharder:patch-1

Conversation

@mikeharder
Copy link
Copy Markdown

Description

use correct path separator in linux commands

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Copilot AI review requested due to automatic review settings April 30, 2026 06:56
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16591

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16591"
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the contributing guide to use the correct shell invocation syntax for macOS/Linux build scripts.

Changes:

  • Fixes macOS/Linux build command from PowerShell-style .\build.sh to POSIX ./build.sh
  • Applies the same fix to the -pack example command
Comment thread docs/contributing.md
## Build the repo

`.\build.sh` (macOS and Linux) or `.\build.cmd` (Windows)
`./build.sh` (macOS and Linux) or `.\build.cmd` (Windows)
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows, the .\\build.cmd command is shown with a single backslash (e.g., .\build.cmd). In Markdown this is fine, but consider using consistent escaping/formatting to avoid copy/paste issues in some renderers (e.g., keep as-is but ensure other docs don’t use \\ or mixed forms). If the repo targets PowerShell, explicitly labeling these as 'PowerShell' vs 'bash/zsh' can reduce confusion.

Copilot uses AI. Check for mistakes.
Comment thread docs/contributing.md

To do so simply execute:
`.\build.sh -pack` (macOS and Linux) or `.\build.cmd -pack` (Windows)
`./build.sh -pack` (macOS and Linux) or `.\build.cmd -pack` (Windows)
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows, the .\\build.cmd command is shown with a single backslash (e.g., .\build.cmd). In Markdown this is fine, but consider using consistent escaping/formatting to avoid copy/paste issues in some renderers (e.g., keep as-is but ensure other docs don’t use \\ or mixed forms). If the repo targets PowerShell, explicitly labeling these as 'PowerShell' vs 'bash/zsh' can reduce confusion.

Copilot uses AI. Check for mistakes.
@mikeharder mikeharder changed the title [docs/contributing.md] use correct path separator in linux commands Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants