Fix not supported field warnings in count_tokens_openai#6987
Merged
ekzhu merged 9 commits intomicrosoft:mainfrom Sep 18, 2025
Merged
Fix not supported field warnings in count_tokens_openai#6987ekzhu merged 9 commits intomicrosoft:mainfrom
ekzhu merged 9 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
|
@seunggil1 can you fix the build errors? |
Contributor
|
@copilot can you create a PR to address the remaining issues based on this branch. |
ekzhu
approved these changes
Sep 18, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6987 +/- ##
==========================================
+ Coverage 80.96% 80.99% +0.03%
==========================================
Files 238 238
Lines 18279 18291 +12
==========================================
+ Hits 14799 14815 +16
+ Misses 3480 3476 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
1.
OpenAIChatCompletionClient.count_tokens(from autogen_ext.models.openai) ignores several JSON Schema fields of Tools (e.g., anyOf, default, title), printing Not supported field ... warnings and producing consistent gaps between the pre-send estimate and usage.prompt_tokens.Autogen Tool description example
Printed warning log
Changes
count_tokens_openaiLimitations
count_tokens_openaifunction, so I just made it similar to other fields.2. In actual requests, Autogen omits the tools parameter when no tools are provided. But the current implementation adds +12 unconditionally, which overcounts tokens for tool-less calls.
Per OpenAI’s cookbook heuristics for tool-call counting, func_end = 12 represents the wrapper overhead that applies only when a tools array exists.
Changes
count_tokens_openaiRelated issue number
Closes #6980
Checks