-
Notifications
You must be signed in to change notification settings - Fork 113
add uv.lock support #1425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add uv.lock support #1425
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1425 +/- ##
=======================================
+ Coverage 89.6% 89.8% +0.2%
=======================================
Files 404 413 +9
Lines 32169 32851 +682
Branches 2003 2040 +37
=======================================
+ Hits 28830 29512 +682
Misses 2928 2928
Partials 411 411 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@grvillic, I created the experiment config as requested. I had to make some adjustments to be able to run it as described in https://github.com/microsoft/component-detection/blob/main/docs/enable-default-off.md, but now I'm able to run it with:
|
src/Microsoft.ComponentDetection.Orchestrator/Services/DetectorRestrictionService.cs
Show resolved
Hide resolved
|
Double check the tests, they seem to be failing in some environments. |
|
@grvillic, I fixed the unit tests and removed the |
src/Microsoft.ComponentDetection.Orchestrator/Experiments/Configs/UvLockDetectorExperiment.cs
Outdated
Show resolved
Hide resolved
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
| /// <summary> | ||
| /// Experiment to validate UvLockComponentDetector against PipComponentDetector. | ||
| /// </summary> | ||
| public class UvLockDetectorExperiment : IExperimentConfiguration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this should have been DefaultOffComponentDetector to begin with https://github.com/microsoft/component-detection/blob/main/docs/creating-a-new-detector.md#detector-lifecycle.
This is an attempt to get uv support started by adding a UvLockComponentDetector.
Hopefully, I am on the right track. Let me know.
uv is gaining adoption within Microsoft. I have been moving Python projects for Azure that I help manage to it. Relevant sections from a
Makefilelook like this:The
locktarget exports arequirements.txtso that this tool can detect security vulnerabilities. See https://docs.astral.sh/uv/concepts/projects/sync/ . This feature would allow us to skip that workaround. It also will allow additional details to be added in follow-up pull requests.