fix: Handle UnicodeDecodeError in PlainTextConverter (#1505)#1540
Open
s3ich4n wants to merge 3 commits intomicrosoft:mainfrom
Open
fix: Handle UnicodeDecodeError in PlainTextConverter (#1505)#1540s3ich4n wants to merge 3 commits intomicrosoft:mainfrom
s3ich4n wants to merge 3 commits intomicrosoft:mainfrom
Conversation
When charset detection samples only the first 4096 bytes and detects 'ascii', but the file contains UTF-8 characters beyond that point, decoding fails with UnicodeDecodeError. Added fallback to charset_normalizer when UnicodeDecodeError occurs, allowing proper handling of files with non-ASCII characters Spanish, Korean, Japanese, Chinese, etc.) that appear after the 4096-byte sample.
Author
|
@microsoft-github-policy-service agree |
bpeloquinm-glitch
approved these changes
Jan 29, 2026
mikeumus
added a commit
to Divinci-AI/markitdown
that referenced
this pull request
Feb 2, 2026
When charset detection samples only the first 4096 bytes and detects 'ascii', but the file contains UTF-8 characters beyond that point, decoding fails with UnicodeDecodeError. Added fallback to charset_normalizer when UnicodeDecodeError occurs, allowing proper handling of files with non-ASCII characters (Spanish, Korean, Japanese, Chinese, etc.) that appear after the 4096-byte sample. Cherry-picked from microsoft/markitdown PR microsoft#1540
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When charset detection samples only the first
4096bytes and detectsascii, but the file contains UTF-8 characters beyond that point, decoding fails withUnicodeDecodeError.Added fallback to
charset_normalizerwhenUnicodeDecodeErroroccurs, allowing proper handling of files with non-ASCII characters Spanish, Korean, Japanese, Chinese, etc.)that appear after the 4096-byte sample.
fixes #1505