Skip to content

Remove test resources before beginning second deployment#2556

Open
hallipr wants to merge 1 commit intomainfrom
users/pahallis/single-deployment
Open

Remove test resources before beginning second deployment#2556
hallipr wants to merge 1 commit intomainfrom
users/pahallis/single-deployment

Conversation

@hallipr
Copy link
Copy Markdown
Member

@hallipr hallipr commented May 1, 2026

What does this PR do?

Adds a step to the CI pipeline to remove test resources before deploying new test resources. This ensure that the first run's resource group isn't left in the subscription after the job completes.

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline
Copilot AI review requested due to automatic review settings May 1, 2026 00:10
@hallipr hallipr requested review from a team as code owners May 1, 2026 00:10
@github-project-automation github-project-automation Bot moved this to Untriaged in Azure MCP Server May 1, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an explicit cleanup step in the live test job to remove previously deployed test resources before kicking off the second test-resources deployment, preventing the first deployment’s resource group from being orphaned when the second deployment overwrites the pipeline variable used for cleanup.

Changes:

  • Insert remove-test-resources.yml between the first live test run and the second test-resources deployment.
  • Reuse the existing cleanup template/conditions to keep behavior consistent with end-of-job cleanup.
@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server May 1, 2026
Copy link
Copy Markdown
Contributor

@jongio jongio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct fix - the mid-pipeline remove prevents the first deployment's resource group from being orphaned when the second deploy overwrites the pipeline variable. Parameters match the existing final cleanup step, and continueOnError: true in the remove template keeps the pipeline safe if removal fails. Variable flow checks out: first deploy sets the RG var, remove cleans it, second deploy sets a new RG var, final cleanup handles that one.

- template: /eng/common/TestResources/remove-test-resources.yml
parameters:
ServiceConnection: azure-sdk-tests-public
EnvVars:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the Pool env needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants