Skip to content

Fix missing freq param in cache update writer locks#2117

Open
Ayush10 wants to merge 1 commit intomicrosoft:mainfrom
Ayush10:fix/issue-2012-cache-data-uri
Open

Fix missing freq param in cache update writer locks#2117
Ayush10 wants to merge 1 commit intomicrosoft:mainfrom
Ayush10:fix/issue-2012-cache-data-uri

Conversation

@Ayush10
Copy link

@Ayush10 Ayush10 commented Jan 31, 2026

Summary

  • Pass freq to C.dpm.get_data_uri() in DiskExpressionCache.update() (line 594) and DiskDatasetCache.update() (line 961)
  • Without freq, get_data_uri() falls back to DEFAULT_FREQ, which raises KeyError when only non-default frequencies are configured

Root Cause

Both update() methods receive a freq parameter but the writer lock calls C.dpm.get_data_uri() without forwarding it. This is inconsistent with all other call sites in the same file which correctly pass freq.

Test plan

  • Verified all other get_data_uri call sites in cache.py pass freq (lines 324, 549, 727, 737, 778, 783, 1155)
  • The two fixed lines are the only ones that were missing the parameter

Fixes #2012

Pass freq to C.dpm.get_data_uri() in DiskExpressionCache.update() and
DiskDatasetCache.update() to avoid KeyError when non-default frequencies
are configured.

Fixes microsoft#2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant