Fix SZSE trading calendar fetch for historical years (2000-2004)#2142
Open
universeplayer wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix SZSE trading calendar fetch for historical years (2000-2004)#2142universeplayer wants to merge 1 commit intomicrosoft:mainfrom
universeplayer wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Remove dead SZSE_CALENDAR_URL constant left behind after the akshare refactor. Remove debug print statements that created unnecessary Ticker network requests. Add error handling around the akshare calendar fetch to provide clear error messages when akshare is not installed or the Sina API is unavailable. Fixes microsoft#2088 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SZSE_CALENDAR_URLconstant left behind after the akshare refactor in refactor(data_collector): use akshare to build unified trade calendar #2093printstatements that created unnecessary Ticker network requests and printed raw objects to stdoutak.tool_trade_date_hist_sina()) to provide clear error messages when akshare is not installed or the Sina API is unavailableTest plan
get_calendar_list("ALL")works correctly with akshare installedImportErrormessage is shown when akshare is not installedFixes #2088
🤖 Generated with Claude Code