Skip to content

Use theme tabRow color as acrylic tint (#19604)#19622

Merged
carlos-zamora merged 1 commit intomicrosoft:mainfrom
EclipseAditya:fix/tabrow-acrylic-theme-color
Jan 12, 2026
Merged

Use theme tabRow color as acrylic tint (#19604)#19622
carlos-zamora merged 1 commit intomicrosoft:mainfrom
EclipseAditya:fix/tabrow-acrylic-theme-color

Conversation

@EclipseAditya
Copy link
Contributor

@EclipseAditya EclipseAditya commented Dec 6, 2025

Summary of the Pull Request

When useAcrylicInTabRow is enabled, the theme's tabRow.background color is now used as the acrylic tint instead of being ignored.

References and Relevant Issues

Fixes #19604

Detailed Description of the Pull Request / Additional comments

Previously, the code had mutually exclusive branches for handling useAcrylicInTabRow and theme tabRow.background. When acrylic was enabled, the theme color was never evaluated.

This PR extracts the theme's tabRow color first, then uses it as the acrylic tint if set, falling back to the default if no theme color is specified.

Validation Steps Performed

Tested with useAcrylicInTabRow: true and custom tabRow.background - acrylic now shows the theme color as tint

PR Checklist

Closes #19604

@EclipseAditya
Copy link
Contributor Author

Hi @DHowett, Can you please review this PR :).

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified this works

Code looks great! Thanks for doing this 😊

@carlos-zamora
Copy link
Member

(pulled out from PR body)

settings.json

{
    "$help": "https://aka.ms/terminal-documentation",
    "$schema": "https://aka.ms/terminal-profiles-schema",
    
    "theme": "BugTestTheme",
    "useAcrylicInTabRow": false,
    
    "themes": [
        {
            "name": "BugTestTheme",
            "tabRow": {
                "background": "#00FF00CC",
                "unfocusedBackground": "#FF0000CC"
            },
            "window": {
                "applicationTheme": "dark"
            }
        }
    ],
    
    "profiles": {
        "defaults": {
            "font": {
                "face": "Cascadia Mono"
            }
        },
        "list": [
            {
                "commandline": "%SystemRoot%\\System32\\WindowsPowerShell\\v1.0\\powershell.exe",
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Windows PowerShell"
            }
        ]
    },
    
    "actions": []
}

with "useAcrylicInTabRow": true
1

with "useAcrylicInTabRow": false
2

@carlos-zamora
Copy link
Member

/azp run

@carlos-zamora carlos-zamora enabled auto-merge (squash) January 12, 2026 21:56
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).
@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.24 Servicing Pipeline Jan 12, 2026
@carlos-zamora carlos-zamora merged commit 6915681 into microsoft:main Jan 12, 2026
14 of 16 checks passed
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.24 Servicing Pipeline Jan 13, 2026
DHowett pushed a commit that referenced this pull request Jan 13, 2026
## Summary of the Pull Request
When `useAcrylicInTabRow` is enabled, the theme's `tabRow.background`
color is now used as the acrylic tint instead of being ignored.

## References and Relevant Issues
Fixes #19604

## Detailed Description of the Pull Request / Additional comments
Previously, the code had mutually exclusive branches for handling
`useAcrylicInTabRow` and theme `tabRow.background`. When acrylic was
enabled, the theme color was never evaluated.

This PR extracts the theme's tabRow color first, then uses it as the
acrylic tint if set, falling back to the default if no theme color is
specified.

## Validation Steps Performed
Tested with `useAcrylicInTabRow: true` and custom `tabRow.background` -
acrylic now shows the theme color as tint

## PR Checklist
Closes #19604

(cherry picked from commit 6915681)
Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgjj6I8
Service-Version: 1.24
@DHowett DHowett moved this from Cherry Picked to Shipped in 1.24 Servicing Pipeline Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants