Use theme tabRow color as acrylic tint (#19604)#19622
Merged
carlos-zamora merged 1 commit intomicrosoft:mainfrom Jan 12, 2026
Merged
Use theme tabRow color as acrylic tint (#19604)#19622carlos-zamora merged 1 commit intomicrosoft:mainfrom
carlos-zamora merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
Hi @DHowett, Can you please review this PR :). |
carlos-zamora
approved these changes
Jan 12, 2026
Member
carlos-zamora
left a comment
There was a problem hiding this comment.
✅ Verified this works
Code looks great! Thanks for doing this 😊
Member
|
(pulled out from PR body) settings.json |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DHowett
pushed a commit
that referenced
this pull request
Jan 13, 2026
## Summary of the Pull Request When `useAcrylicInTabRow` is enabled, the theme's `tabRow.background` color is now used as the acrylic tint instead of being ignored. ## References and Relevant Issues Fixes #19604 ## Detailed Description of the Pull Request / Additional comments Previously, the code had mutually exclusive branches for handling `useAcrylicInTabRow` and theme `tabRow.background`. When acrylic was enabled, the theme color was never evaluated. This PR extracts the theme's tabRow color first, then uses it as the acrylic tint if set, falling back to the default if no theme color is specified. ## Validation Steps Performed Tested with `useAcrylicInTabRow: true` and custom `tabRow.background` - acrylic now shows the theme color as tint ## PR Checklist Closes #19604 (cherry picked from commit 6915681) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgjj6I8 Service-Version: 1.24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When
useAcrylicInTabRowis enabled, the theme'stabRow.backgroundcolor is now used as the acrylic tint instead of being ignored.References and Relevant Issues
Fixes #19604
Detailed Description of the Pull Request / Additional comments
Previously, the code had mutually exclusive branches for handling
useAcrylicInTabRowand themetabRow.background. When acrylic was enabled, the theme color was never evaluated.This PR extracts the theme's tabRow color first, then uses it as the acrylic tint if set, falling back to the default if no theme color is specified.
Validation Steps Performed
Tested with
useAcrylicInTabRow: trueand customtabRow.background- acrylic now shows the theme color as tintPR Checklist
Closes #19604