Parse new DeclarationReference format in TSDoc #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
force-pushed
the
parse-beta-declref
branch
from
aa19c00 to
4f616ff
Compare
rbuckton
force-pushed
the
parse-beta-declref
branch
from
4f616ff to
cd81fc9
Compare
Collaborator
|
@rbuckton Thanks for contributing this PR! I apologize I haven't had a chance to look at it yet. I've been very busy the past week, but I should have some time on Friday. |
Contributor
|
One concern I have: This new form of declaration references appears to be incapable of supporting the tsdoc/tsdoc/src/beta/DeclarationReference.grammarkdown Lines 157 to 161 in b7bddc1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #324 to support parsing the new DeclarationReference format in TSDoc.