feat: make deno easier to configure#1348
Merged
Merged
Conversation
Previously deno required manually configuring runtimeArgs and port
flags, with manual selection of the debug port to use[1]
This adds a little bit of extra logic so that all the necessary
configuration for Deno is automatically wired up whenever the user sets
their runtimeExectuable to `deno`. For example, this now works:
```json
{
"type": "node"
"name": "Launch Program",
"program": "${workspaceFolder}/hello.ts",
"runtimeExecutable": "deno",
"request": "launch",
}
```
Where previously it was:
```json
{
"type": "node"
"name": "Launch Program",
"program": "${workspaceFolder}/hello.ts",
"runtimeExecutable": "deno",
"request": "launch",
"attachSimplePort": "9229",
"continueOnAttach": true,
"runtimeArgs": ["run", "--inspect-brk=127.0.0.1:9229", "--allow-all"]
}
```
1. https://medium.com/deno-the-complete-reference/run-and-debug-deno-applications-in-vscode-b6e3bff217f
connor4312
force-pushed
the
deno-easy-config
branch
from
60be89b to
08b81dc
Compare
mjbvz
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously deno required manually configuring runtimeArgs and port
flags, with manual selection of the debug port to use[1]
This adds a little bit of extra logic so that all the necessary
configuration for Deno is automatically wired up whenever the user sets
their runtimeExectuable to
deno. For example, this now works:{ "type": "node" "name": "Launch Program", "program": "${workspaceFolder}/hello.ts", "runtimeExecutable": "deno", "request": "launch", }Where previously it was:
{ "type": "node" "name": "Launch Program", "program": "${workspaceFolder}/hello.ts", "runtimeExecutable": "deno", "request": "launch", "attachSimplePort": "9229", "continueOnAttach": true, "runtimeArgs": ["run", "--inspect-brk=127.0.0.1:9229", "--allow-all"] }Note thatcontinueOnAttachdoesn't quite work pending denoland/deno#15360