npm extension - check for root package.json before findFiles#124803
Merged
meganrogge merged 1 commit intomicrosoft:mainfrom Jan 22, 2024
nrayburn-tech:npm-activation
Merged
npm extension - check for root package.json before findFiles#124803meganrogge merged 1 commit intomicrosoft:mainfrom nrayburn-tech:npm-activation
meganrogge merged 1 commit intomicrosoft:mainfrom
nrayburn-tech:npm-activation
Conversation
alexr00
approved these changes
Dec 11, 2023
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Makes sense to me! @meganrogge, I haven't tested this but the change looks good.
meganrogge
approved these changes
Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching the workspace root for a
package.jsonbefore triggering thefindFilescall decreases the extension activation time for workspaces that have a rootpackage.json.