Fix for #200257 plus existing trailing non-numerics regex fix

[sparxooo]

This is a draft PR for a fix for issue #200257

Whilst figuring how to fix the issue I created, it appeared that the regex at terminalLinkOpeners.ts:111 was incorrect. Here are the old and new regex side by side, with what I expect the original coder intended. I also tested grep output with filenames/line numbers, and that seems to be correct also.

The trailing period issue has also been fixed with a new text.replace step with (hopefully) a correct regex, that currently only removes trailing periods from line/column numbers (for instance, "test.ts." should be left alone).

The big question possibly is, is there any reason why a trailing period on a link should remain? If not, I guess you could just remove any trailing period regardless of it's preceding text.

[sparxooo]

@microsoft-github-policy-service agree

[Tyriar]

Love the tests 👏

[sparxooo]

Latest commit I have updated the regex at terminalLinkOpeners.ts:111 in-line with Tyriar's suggestion.

I have updated the TerminalSearchLinkOpener test suite with extra tests for the altered Grep/Ruby regex, plus the trailing period regex. These tests include both line number only, and line / column number tests. I also added line number only tests to the "workspace with spaces" test for completeness.

[Tyriar]

Great work! 👏

[sparxooo]

Thanks Tyriar

Regarding the trailing period issue, although this will catch this:
Check your code at Test.ts:10.

It won't catch this:
Check your code in Test.ts.

If I changed the trailing period regex line to
text = text.replace(/\.$/, '');

Then it would gracefully handle Test.ts., but would in theory break anyone using trailing periods in filenames (if that is even going to be a concern).

[Tyriar]

It's hard to say what the right behavior is here as these links are meant to be very simple and driven by the terminal.integrated.wordSeparators setting. I guess it is preferable to go with the optimistic case and remove the . as excluding it will show results both with and without the ., but including it will only show results including the .