Fix optionalReplacementSpan not being applied to completion entries#200945
Merged
mjbvz merged 3 commits intomicrosoft:mainfrom Jan 3, 2024
Merged
Fix optionalReplacementSpan not being applied to completion entries#200945mjbvz merged 3 commits intomicrosoft:mainfrom
mjbvz merged 3 commits intomicrosoft:mainfrom
Conversation
mjbvz
previously approved these changes
Dec 15, 2023
Collaborator
|
formatting error in the linter? |
rzhao271
reviewed
Dec 15, 2023
extensions/typescript-language-features/src/languageFeatures/completions.ts
Show resolved
Hide resolved
rzhao271
approved these changes
Dec 15, 2023
Contributor
Author
It seems to be caused by my branch not being up to date and merging branch on CI, now it should fixed. |
joyceerhl
approved these changes
Dec 15, 2023
Contributor
Author
|
@mjbvz auto-merge has been suspended by comments, can you enable it again? Thanks! |
mjbvz
approved these changes
Jan 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix the problem with the first video shown at vuejs/language-tools#3789 (comment).
If TS CompletionEntry has no replacementSpan, VSCode will fallback to the wordPattern of the language configuration, but for Vue documents, VSCode will not use the wordPattern of the embedded language, but the wordPattern of the vue language, so the
$xxxvariable will not be replaced correctly.