Skip to content

fix: memory leak in gettingStarted#216876

Merged
bhavyaus merged 6 commits intomicrosoft:mainfrom
SimonSiefke:fix/memory-leak-getting-started
Oct 27, 2025
Merged

fix: memory leak in gettingStarted#216876
bhavyaus merged 6 commits intomicrosoft:mainfrom
SimonSiefke:fix/memory-leak-getting-started

Conversation

@SimonSiefke
Copy link
Contributor

Fixes #216858

Testing

For testing I ran the test script from the issue description for expanding/collapsing a section in the gettingStartedView 97 times. The number of added iframe elements was reduced from 97 to 0 and the number of added event listeners was reduced from 1163 to 4.

@mjbvz mjbvz assigned sandy081 and bhavyaus and unassigned mjbvz and sandy081 Jun 24, 2024
@bpasero bpasero added this to the October 2025 milestone Oct 15, 2025
@bpasero bpasero enabled auto-merge (squash) October 15, 2025 08:21
@bpasero bpasero closed this Oct 15, 2025
auto-merge was automatically disabled October 15, 2025 09:52

Pull request was closed

@bpasero bpasero reopened this Oct 15, 2025
@bpasero bpasero enabled auto-merge (squash) October 15, 2025 09:52
@bpasero bpasero closed this Oct 15, 2025
auto-merge was automatically disabled October 15, 2025 13:56

Pull request was closed

@bpasero bpasero reopened this Oct 15, 2025
@bhavyaus bhavyaus merged commit 12b90e5 into microsoft:main Oct 27, 2025
32 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 13, 2025
@SimonSiefke SimonSiefke deleted the fix/memory-leak-getting-started branch January 15, 2026 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

6 participants