fix: memory leak in InlayHints#265185
Merged
jrieken merged 8 commits intomicrosoft:mainfrom Oct 6, 2025
Merged
Conversation
Member
|
This will also fix #259985 |
jrieken
approved these changes
Oct 6, 2025
alexr00
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
Scrolling up and down in an editor 197 times:
It seems that when scrolling the the inlay hints are queried and added to
sessionDisposablesmakingsessionDisposablesgrow by one each time.Change
The change uses a separate
disposableStoreso that each time theRunOnceSchedulerruns, the previousdisposableStoreremoved and disposed.In order to not manage the
cancelToken,disposableStoreandmutableDisposableindividually, a new classCancellationStorehas been added that combines them.