fix: memory leak in chat session tracker

[SimonSiefke]

Fixes a memory leak in the chat session tracker.

Overview

The chat session tracker registers a listener to a group each time a group is added. But when a group is removed, the listener doesn't seem to be disposed.

// Listen for new groups
this._register(this.editorGroupsService.onDidAddGroup(group => {
  this.registerGroupListeners(group);
}));

Change

The change is to also listen for group removal events and dispose the group change listener for the group when the group is removed:

// Listen to all editor groups
this.editorGroupsService.groups.forEach(group => {
	this.groupDisposables.set(group.id, this.registerGroupListeners(group));
});

// Listen for new groups
this._register(this.editorGroupsService.onDidAddGroup(group => {
	this.groupDisposables.set(group.id, this.registerGroupListeners(group));
}));

// listen for groups to be removed
this.editorGroupsService.onDidRemoveGroup(group => {
	this.groupDisposables.deleteAndDispose(group.id); // remove listener
});

Results after change

After the change there seem to be no more chat session tracker leaks.

[bpasero]

Merge conflict.

[vs-code-engineering]

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

• src/vs/workbench/contrib/chat/browser/chatSessions/chatSessionTracker.ts