Chat: Show provider instance name for duplicate BYOK models in model picker#312028
Merged
lramos15 merged 4 commits intoApr 24, 2026
Merged
Conversation
When resolving grouped language model providers, replace model metadata detail with the configured group name. This lets users distinguish duplicate models from multiple instances of the same vendor (for example Local vs Remote Ollama). Also adds a unit test that verifies two groups from the same vendor produce distinct detail labels in the picker metadata. Signed-off-by: Charlie Fish <contact@charlie.fish>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Chat’s model picker labeling for grouped language model providers so that duplicate models from the same vendor can be distinguished by the configured provider instance (group) name.
Changes:
- Override grouped language model
metadata.detailto use the provider group name during grouped model resolution. - Add a unit test validating that the same model ID exposed by multiple groups resolves with distinct
detailvalues matching the group names.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/languageModels.ts |
Overrides grouped model metadata.detail with the configured provider group name during model resolution. |
src/vs/workbench/contrib/chat/test/common/languageModels.test.ts |
Adds a unit test ensuring grouped instances produce distinct detail values for duplicate models. |
Co-authored-by: Copilot <copilot@github.com>
Member
|
How do we feel about just not setting |
Contributor
Author
lramos15
approved these changes
Apr 23, 2026
pwang347
approved these changes
Apr 24, 2026
Contributor
Author
|
@lramos15 Seems like this broke in a recent Insiders build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates Chat model picker labeling for grouped language model providers so duplicate models from the same vendor are distinguishable by provider instance name.
Specifically, when resolving grouped models, the displayed model detail now uses the configured provider group name (for example, Local MacBook, Remote Linux) instead of the generic vendor label (for example, Ollama).
Fixes #312025
Problem
When users configure multiple Ollama providers and those providers expose overlapping model names, the model picker showed the same generic label for each duplicate row. That made it unclear which backend was being selected.
Change
Why this approach
Tests
Automated
Manual
Screenshots
Before
After
Risk and impact