Fix case-insensitive aggregated basename glob matching - #316387
Merged
Dmitriy Vasyura (dmitrivMS) merged 8 commits intoAug 19, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Danyal Ahmed (danyalahmed1995)
May 14, 2026 09:51
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes case-insensitive matching for aggregated basename-only glob expressions in the base glob matcher, preserving expected ignoreCase behavior when multiple basename patterns are combined into the fast path.
Changes:
- Passes
ignoreCaseinto basename aggregation for both brace-expanded string patterns and expression patterns. - Uses case-insensitive basename comparison in the aggregate matcher when requested.
- Adds regression coverage for multiple basename-only expression patterns with
ignoreCase: true.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/base/common/glob.ts |
Updates aggregated basename matching to honor ignoreCase. |
src/vs/base/test/common/glob.test.ts |
Adds a regression test for case-insensitive aggregated basename expression matching. |
Dmitriy Vasyura (dmitrivMS)
assigned
Dmitriy Vasyura (dmitrivMS) and unassigned
Anthony Kim (anthonykim1)
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
August 16, 2026 22:50
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 16, 2026 23:11
View session
Dmitriy Vasyura (dmitrivMS)
requested changes
Aug 16, 2026
Dmitriy Vasyura (dmitrivMS)
left a comment
Dmitriy Vasyura (dmitrivMS)
left a comment
Collaborator
There was a problem hiding this comment.
Please add requested test
auto-merge was automatically disabled
August 17, 2026 04:46
Head branch was pushed to by a user without write access
Contributor
Author
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 17, 2026 05:45
View session
Dmitriy Vasyura (dmitrivMS)
previously approved these changes
Aug 17, 2026
Collaborator
|
Danyal Ahmed (@danyalahmed1995) Thank you! |
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
August 17, 2026 05:53
Christof Marti (chrmarti)
previously approved these changes
Aug 17, 2026
Dmitriy Vasyura (dmitrivMS)
disabled auto-merge
August 17, 2026 08:44
Dmitriy Vasyura (dmitrivMS)
marked this pull request as draft
August 17, 2026 08:52
Danyal Ahmed (danyalahmed1995)
dismissed stale reviews from Christof Marti (chrmarti) and Dmitriy Vasyura (dmitrivMS)
via
August 17, 2026 09:00
66e5be7
Contributor
Author
|
Dmitriy Vasyura (@dmitrivMS) done , preserved the expression glob casing with cached patterns |
Danyal Ahmed (danyalahmed1995)
marked this pull request as ready for review
August 18, 2026 12:38
Danyal Ahmed (danyalahmed1995)
requested a review
from Dmitriy Vasyura (dmitrivMS)
August 18, 2026 12:39
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 18, 2026 16:42
View session
Dmitriy Vasyura (dmitrivMS)
requested changes
Aug 18, 2026
Dmitriy Vasyura (dmitrivMS)
left a comment
Dmitriy Vasyura (dmitrivMS)
left a comment
Collaborator
There was a problem hiding this comment.
See Copilot's comment.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Dmitriy Vasyura (@dmitrivMS) applied the co pilot suggestion. |
Collaborator
Is there a way to add a test for this change? |
Contributor
Author
|
Dmitriy Vasyura (@dmitrivMS) Added a test for this change. It covers the reverse cache order and confirms that the matcher returns the key from the current expression. All 52 glob tests are passing. |
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 18, 2026 22:18
View session
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
August 18, 2026 22:36
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 18, 2026
roblourens
approved these changes
Aug 19, 2026
Christof Marti (chrmarti)
approved these changes
Aug 19, 2026
Dileep Yavanmandha (dileepyavan)
pushed a commit
that referenced
this pull request
Aug 19, 2026
* Fix case-insensitive aggregated basename glob matching * Added the requested review test * Preserve expression glob casing with cached patterns * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Add reverse cache collision regression test --------- Co-authored-by: Dmitriy Vasyura <dmitriv@microsoft.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a glob matching edge case where basename-only glob expressions did not honor
ignoreCase: trueafter being combined by the basename aggregation fast path.For example, matching multiple basename-only patterns such as
**/BARand**/BAZagainstbarwithignoreCase: truereturnednull, while the equivalent single-pattern case honoredignoreCase.The aggregate path now preserves case-insensitive matching semantics while keeping case-sensitive behavior unchanged.
Validation
Added regression coverage for aggregated basename-only glob expressions with
ignoreCase: true.Ran:
git diff --checknpm run compile-check-ts-native- failed before typechecking becausetsgois unavailable in this checkout