Add chatSessionId to chat.modelChange telemetry#322579
Merged
aashna merged 3 commits intoJun 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a chat-session correlation identifier to the chat.modelChange telemetry event so model-picker switches can be associated with the active chat conversation/session.
Changes:
- Extend the model picker delegate API with an optional
getConversationId()hook. - Emit
conversationIdon thechat.modelChangetelemetry event when the user selects a different model. - Wire the chat input’s delegate implementation to derive the ID from the current session resource.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/modelPickerActionItem.ts | Adds optional delegate method for providing the current conversation/session correlation id. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Extends chat.modelChange telemetry schema and logs the conversation id on model selection. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Implements the delegate hook by converting the current session resource to an id. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
Sid200026
force-pushed
the
chat-modelchange-conversation-id
branch
from
1cb0b44 to
854f47f
Compare
benibenj
previously approved these changes
Jun 23, 2026
…ersation-id # Conflicts: # src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts
auto-merge was automatically disabled
June 25, 2026 17:20
Head branch was pushed to by a user without write access
bhavyaus
approved these changes
Jun 26, 2026
benvillalobos
approved these changes
Jun 26, 2026
TylerLeonhardt
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correlate explicit model-picker switches with the conversation by emitting the chat session id