Skip to content

Add quota checkpoint to notification telemetry#322767

Merged
lramos15 merged 3 commits into
microsoft:mainfrom
rfeltis:rfeltis/322746-checkpoint-banner-telemetry
Jun 24, 2026
Merged

Add quota checkpoint to notification telemetry#322767
lramos15 merged 3 commits into
microsoft:mainfrom
rfeltis:rfeltis/322746-checkpoint-banner-telemetry

Conversation

@rfeltis

@rfeltis rfeltis commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #322746

This appends the quota checkpoint percentage to quota approaching chat input notification telemetry IDs, so each checkpoint can be analyzed separately.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 24, 2026 16:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make chat quota “approaching” notification telemetry more granular by including the checkpoint percentage in the telemetryId, enabling analysis per checkpoint (per #322746).

Changes:

  • Append a percentage suffix to the telemetryId for quota-approaching chat input notifications.
  • Update the quota notification integration test to expect the new telemetryId shape for the 75% checkpoint.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/chatQuotaNotification.ts Updates quota-approaching notification telemetryId to include a percent suffix.
src/vs/workbench/contrib/chat/test/browser/chatQuotaNotification.integrationTest.ts Updates expected telemetry ID for the quota-approaching test case to include the checkpoint value.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
Comment thread src/vs/workbench/contrib/chat/browser/chatQuotaNotification.ts
@lramos15 lramos15 merged commit 08b4ec4 into microsoft:main Jun 24, 2026
28 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.127.0 milestone Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants