Copilot SDK upgrade validation#323742
Draft
pwang347 wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds build-time validations around Copilot CLI SDK upgrades, focusing on macOS universal-app packaging rules and preventing dependency version drift across the VS Code manifests. It centralizes the macOS universal merge glob configuration and introduces tests that catch common upgrade pitfalls earlier (locally via cd build && npm test) instead of during later macOS pipeline stages.
Changes:
- Centralize Copilot-related macOS universal merge glob patterns in
build/lib/copilot.tsand reuse them from the universal app builder. - Add a helper (
findUncoveredCopilotDarwinBinaries) plus tests to ensure known darwin native binary locations remain covered by the universal merge globs. - Add tests ensuring
@github/copilot(root/remote/extension) and@github/copilot-sdk(root/remote) versions stay in sync across manifests.
Show a summary per file
| File | Description |
|---|---|
| build/lib/test/copilot.test.ts | Adds new test suites for macOS universal packaging glob coverage and for Copilot/Copilot-SDK version consistency across manifests. |
| build/lib/copilot.ts | Introduces exported universal-merge glob sets and a helper to detect darwin native binaries not covered by those globs. |
| build/darwin/create-universal-app.ts | Switches hardcoded Copilot glob lists to imports from build/lib/copilot.ts and composes x64ArchFiles from the centralized glob list. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Low
…t breaks Re-enables the skipped 'opens a Copilot CLI session and receives a response' smoke test (skipped in #320344 as a stopgap while the session path was failing). Adds an isSdkContractFailure classifier so an API break like the removed callback hooks surfaces as a clear 'SDK rejected a session option' diagnostic instead of a generic timeout. This is the gate that catches native-runtime breaks (e.g. #323657) which no mocked unit test can.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.