Enhance CopilotSlashCommandCompletionProvider with session customizations and improve command handling#323931
Draft
DonJayamanne wants to merge 3 commits into
Draft
Enhance CopilotSlashCommandCompletionProvider with session customizations and improve command handling#323931DonJayamanne wants to merge 3 commits into
DonJayamanne wants to merge 3 commits into
Conversation
…ions and improve command handling
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances Copilot’s slash-command completion flow in the agent host by incorporating session customizations (to suppress duplicate skill suggestions) and by adding runtime skill handling (including mid-message / token completions). It also adjusts runtime command dispatch/listing so skills are available from the runtime catalog and aren’t incorrectly invoked as regular commands.
Changes:
- Extend
CopilotSlashCommandCompletionProviderto (a) support whitespace-delimited slash tokens for skill-only completions and (b) filter runtime skill completions based on session-known skills/customizations. - Update runtime command handling so skills are included in the runtime command catalog and are not invoked through the
commands.invokepath. - Add extensive unit tests covering runtime skill completion behaviors and deduplication against session customizations.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/test/node/copilotSlashCommandCompletionProvider.test.ts | Adds test coverage for runtime skill completions and filtering against known (customization-provided) skills. |
| src/vs/platform/agentHost/node/copilot/copilotSlashCommandCompletionProvider.ts | Implements session-customization-aware runtime skill completion, skill hint handling, and in-message slash token behavior. |
| src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts | Includes runtime skills in the command list cache and avoids invoking skills via the command-invoke RPC path. |
| src/vs/platform/agentHost/node/copilot/copilotAgent.ts | Wires session customizations into the completion provider so it can compute “known skills” per session. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Review effort level: Low
…session check in _getKnownSkills and ensure sessionInfo is always accessed safely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.