AgentHost - fix opening files when using checkpoint refs#323932
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Agent Host git blob retrieval path to support non-SHA references (e.g. checkpoint refs) when opening “before” content via git show <ref>:<path>.
Changes:
- Widen
AgentHostGitService.showBlobfrom hex-only SHAs to general git refs. - Update the
IAgentHostGitServiceAPI docs/signature to userefterminology. - Adjust the integration test to use
refnaming for the blob source revision.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/test/node/agentHostGitService.integrationTest.ts | Renames the test variable to ref for the showBlob call. |
| src/vs/platform/agentHost/node/agentHostGitService.ts | Changes showBlob to accept a general ref (removing the prior SHA validation) and uses it in git show. |
| src/vs/platform/agentHost/common/agentHostGitService.ts | Updates the interface documentation and parameter naming from sha to ref. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Low
DonJayamanne
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.