fix: memory leak in markersTable - #327885
Merged
Ladislau Szomoru (lszomoru) merged 3 commits intoAug 17, 2026
Merged
Conversation
Ladislau Szomoru (lszomoru)
approved these changes
Aug 17, 2026
Ladislau Szomoru (lszomoru)
enabled auto-merge (squash)
August 17, 2026 13:20
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 17, 2026
Kyle Cutler (kycutler)
approved these changes
Aug 17, 2026
Collaborator
|
Simon Siefke (@SimonSiefke) Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Link-style diagnostic codes create a new
HighlightedLabelfor each Problems table row. The label was owned by the table template, so removed rows stayed reachable until the template was disposed.Change
Separate template and element disposables and clear per-row labels, action-bar items, and listeners when a table element is disposed.
Before
When repeatedly removing and re-adding a linked diagnostic in the Problems table for 37 runs,
HighlightedLabelgrows by 37 instances:After
No more matching
HighlightedLabelleak is detected.Test Video
markers-table-diagnostic-refresh-after.webm