Fix file URL to path conversion in html-language-features esbuild script

[Jade Ferreira Vieira (jadefr)]

Fix file URL to path conversion in html-language-features esbuild script

import.meta.resolve('typescript') returns a file:// URL, and the code converts it to a path with a plain string replace instead of a proper URL-to-path conversion.

The problem

Windows always fails: stripping file:// leaves /C:/Users/..., an invalid path (extra slash before the drive letter). Downstream path.join/fs calls resolve it against the current drive, producing a doubled path like C:\C:\Users\..., so npm run compile-web fails:

ENOENT: no such file or directory, open 'C:\C:\Users\...\lib\lib.es2020.full.d.ts'

Any OS fails too if the path contains a percent-encoded character — most commonly a space (e.g. ~/My Projects/...). The replace never decodes it, so file:///home/user/My%20Projects/.../typescript.js becomes a literal, nonexistent path — ENOENT again.

This went unnoticed because it needs either Windows, or a special character somewhere in the path — a plain path like ~/repos/vscode never triggers it. Windows hits it far more often in practice too: spaces are common in default Windows paths (C:\Program Files\, OneDrive - Company Name\), while Linux/macOS convention mostly avoids them.

The fix

fileURLToPath() (node:url) is Node's built-in, spec-correct URL-to-path converter — it handles both the drive-letter and percent-decoding cases. For simple paths it's a no-op on Linux/macOS; it only changes behavior where the old code was wrong.

Testing

Verified on Windows 11:

• npm run compile-web and npm run compile-client — 0 errors (previously failed)
• Runtime: opened a new .html file, typed <script> inside it, got correct JS/DOM IntelliSense — confirming the TypeScript lib .d.ts files actually load, not just that the build succeeds
• Reproduced both failure modes in isolation (Windows drive-letter case, and percent-encoding case with a space in the path) and confirmed the fix resolves each

[Copilot]

Pull request overview

Corrects TypeScript library path resolution in the HTML language features browser build.

Changes:

• Uses Node’s fileURLToPath() for Windows paths and percent-encoded characters.