refactor: share the find input toggle navigation

[Bedirhan ÇETİN (Xaena53)]

Fixes #199892

FindInput and ReplaceInput each carried their own copy of the arrow-key / Escape handling that moves focus between the toggles of a find input. The two blocks were identical apart from how the toggle elements are collected — FindInput resolves them through getToggleDomNodes(), ReplaceInput captures [this.preserveCase.domNode] up front.

This extracts the block into navigateToggles in findInputToggles.ts and calls it from both widgets. The extracted body is unchanged from the code that was removed; only this.getToggleDomNodes(), this.domNode and this.inputBox.focus() became parameters, so the diff should read as a straight move.

One detail worth calling out: the toggles are passed as a callback rather than as an array. FindInput only called getToggleDomNodes() after the key check, so passing the array eagerly would have resolved the toggles on every keystroke in the widget. The callback keeps the original laziness, and there is a test covering it.

How to test

Open the editor find widget (Ctrl+F), move focus into the toggles (Match Case / Match Whole Word / Use Regular Expression) and use Left/Right to move between them and Escape to go back to the input. The replace input's Preserve Case toggle behaves the same way.

Verification

Added src/vs/base/test/browser/ui/findinput/findInputToggles.test.ts covering wrap-around in both directions, Escape returning focus to the input, focus outside the toggles being ignored, and the lazy resolution described above.

node test/unit/browser/index.js --run src/vs/base/test/browser/ui/findinput/findInputToggles.test.ts --browser chromium
  5 passing

node test/unit/browser/index.js --runGlob "vs/base/test/browser/**/*.test.js" --browser chromium
  511 passing

node test/unit/browser/index.js --runGlob "vs/editor/contrib/find/**/*.test.js" --browser chromium
  76 passing

node test/unit/browser/index.js --runGlob "vs/workbench/contrib/search/**/*.test.js" --browser chromium
  68 passing

tsc --noEmit -p src/tsconfig.json and eslint on the touched files are both clean.

I was not able to run a full desktop build locally — the native modules need the Spectre-mitigated MSVC libraries, which my toolchain is missing — so the keyboard behaviour above is covered by the unit tests rather than by a manual pass in a built VS Code.

[Copilot]

Pull request overview

Refactors find/replace toggle keyboard navigation into a shared helper, resolving #199892 without changing behavior.

Changes:

• Extracts arrow-key and Escape handling into navigateToggles.
• Reuses the helper in FindInput and ReplaceInput.
• Adds focused tests for navigation, focus restoration, and lazy toggle resolution.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
src/vs/base/browser/ui/findinput/findInputToggles.ts	Adds the shared navigation helper.
src/vs/base/browser/ui/findinput/findInput.ts	Uses the shared helper for find toggles.
src/vs/base/browser/ui/findinput/replaceInput.ts	Uses the shared helper for Preserve Case.
src/vs/base/test/browser/ui/findinput/findInputToggles.test.ts	Tests navigation and lazy resolution.

[Bedirhan ÇETİN (Xaena53)]

@microsoft-github-policy-service agree