Rename Voice Mode voices to approved names - #329576
Merged
Megan Rogge (meganrogge) merged 1 commit intoAug 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renames Voice Mode voices to approved product names and migrates legacy identifiers while retaining existing preview assets.
Changes:
- Adds canonical voice-ID normalization and persistence migration.
- Updates settings, onboarding labels, previews, and tests.
- Makes application-scope configuration migration opt-in.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/test/common/configuration.test.ts |
Tests application migration opt-in. |
src/vs/workbench/common/configuration.ts |
Adds application-target migration support. |
src/vs/workbench/contrib/agentsVoice/browser/agentsVoice.contribution.ts |
Renames settings and registers migration. |
src/vs/workbench/contrib/agentsVoice/browser/voiceModeOnboarding.ts |
Uses canonical IDs with legacy preview assets. |
src/vs/workbench/contrib/agentsVoice/test/browser/voiceModeOnboarding.test.ts |
Updates onboarding expectations. |
src/vs/workbench/contrib/chat/common/voiceClient/voiceClientService.ts |
Adds voice-ID normalization. |
src/vs/workbench/contrib/chat/browser/voiceClient/voiceClientService.ts |
Normalizes backend wire values. |
src/vs/workbench/contrib/chat/test/browser/voiceClient/voiceClientService.test.ts |
Tests legacy-ID normalization. |
Comment on lines
+15
to
+26
| switch (voiceId) { | ||
| case 'victoria_neutral': | ||
| return 'harper_neutral'; | ||
| case 'maya_neutral': | ||
| return 'birch_neutral'; | ||
| case 'daniel_neutral': | ||
| return 'junho_neutral'; | ||
| case 'kevin_neutral': | ||
| return 'oak_neutral'; | ||
| default: | ||
| return voiceId || 'birch_neutral'; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Good catch, fixed. normalizeAgentsVoiceId now explicitly allow-lists the four canonical IDs before the legacy-alias cases, and any other value (including manually-edited/unknown strings) falls back to birch_neutral instead of passing through unchanged. This matters most for the new migration path, which persists the result; an unrecognized value should not get baked into the closed four-value enum. Added an unknown_voice case to the parameterized test.
Arthur Cnops (accnops)
force-pushed
the
voice-mode-approved-voice-names
branch
2 times, most recently
from
August 7, 2026 12:01
54f97b5 to
c949dfb
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: b00ba5be-f710-4520-a5f4-3684b0facaf5
Arthur Cnops (accnops)
force-pushed
the
voice-mode-approved-voice-names
branch
from
August 7, 2026 12:22
c949dfb to
9ef1045
Compare
Megan Rogge (meganrogge)
approved these changes
Aug 7, 2026
Megan Rogge (meganrogge)
enabled auto-merge (squash)
August 7, 2026 15:01
roblourens
approved these changes
Aug 7, 2026
roblourens
approved these changes
Aug 7, 2026
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on https://github.com/infinity-microsoft/yolo/pull/65877 for backend canonical-ID support.
Testing
npm run transpile-client -- --outputDir out./scripts/test.sh --run src/vs/workbench/test/common/configuration.test.ts --run src/vs/workbench/contrib/agentsVoice/test/browser/voiceModeOnboarding.test.ts --run src/vs/workbench/contrib/chat/test/browser/voiceClient/voiceClientService.test.ts --timeout 30000(50 passing)npm run valid-layers-check