Skip to content

Weekly Permissions sync 2026-04-28#1512

Closed
marabooy wants to merge 2 commits intomasterfrom
permissions-update/2026-04-28
Closed

Weekly Permissions sync 2026-04-28#1512
marabooy wants to merge 2 commits intomasterfrom
permissions-update/2026-04-28

Conversation

@marabooy
Copy link
Copy Markdown
Contributor

Weekly Permissions sync 2026-04-28

@marabooy marabooy requested a review from a team as a code owner April 28, 2026 00:26
Copilot AI review requested due to automatic review settings April 28, 2026 00:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Weekly permissions sync updating the permissions catalog and provisioning metadata to reflect newly onboarded/updated scopes and API path mappings.

Changes:

  • Enabled and assigned IDs for AgentRegistration.* in provisioningInfo.json, and added corresponding AgentRegistration.* scope definitions in permissions.json.
  • Added/updated permission provisioning entries (e.g., new calendar app-only variants, AppGalleryIntegrationRequest updates, new print-related entries).
  • Updated multiple permission-to-path mappings (e.g., agent sign-in sessions paths, Cloud PC set device name action, new Network Access report function, new Reports endpoint, and a new Print alert settings ReadWrite permission).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
permissions/new/provisioningInfo.json Updates provisioning metadata: toggles/enables IDs, adds new permission deployment entries, and adjusts resourceAppId mappings.
permissions/new/permissions.json Updates permission definitions and expands pathSets for several permissions, including new AgentRegistration.* scopes and print/network/report path mappings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -680,37 +680,37 @@
],
"AgentRegistration.Read.All": [
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentRegistration.Read.All appears to be indented one extra space compared to surrounding top-level permission keys, which breaks the file’s otherwise consistent 2-space JSON indentation and makes diffs harder to scan. Align this key with the other top-level keys in the object.

Suggested change
"AgentRegistration.Read.All": [
"AgentRegistration.Read.All": [
Copilot uses AI. Check for mistakes.
Comment on lines 8263 to 8264
"InfoProtectABACPolicy.Read.All": [
{
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The InfoProtectABACPolicy.Read.All key (and the start of its array) is indented differently than surrounding top-level permission keys/array items in this file. Please realign it to match the established indentation pattern for top-level permission keys and their array items to keep formatting consistent.

Copilot uses AI. Check for mistakes.
Comment on lines +3113 to +3117
"adminDisplayName": "Read all agent registrations",
"adminDescription": "Allows the user to read all agent registration information",
"userDisplayName": "Read all agent registrations",
"userDescription": "Allows the app to read agent registration information.",
"requiresAdminConsent": false,
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For AgentRegistration.Read.All (DelegatedWork), the description strings are internally inconsistent (adminDescription says “Allows the user…”, while userDescription says “Allows the app…”) and they omit the common “on behalf of the signed-in user / on your behalf” phrasing used elsewhere for delegated permissions. Consider aligning both descriptions to the standard delegated wording to avoid confusion on consent screens.

Copilot uses AI. Check for mistakes.
Comment on lines +3149 to +3153
"adminDisplayName": "Read and write all agent registrations",
"adminDescription": "Allows the user to read and write all agent registration information",
"userDisplayName": "Read and write all agent registrations",
"userDescription": "Allows the app to read and write agent registration information.",
"requiresAdminConsent": true,
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For AgentRegistration.ReadWrite.All (DelegatedWork), the consent descriptions have the same inconsistency as the read scope (“Allows the user…” vs “Allows the app…”) and don’t follow the usual delegated phrasing (“on behalf of the signed-in user” / “on your behalf”). Aligning these strings with the established pattern will make consent prompts clearer and consistent.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants