Skip to content

Conversation

@zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Nov 1, 2025

pr: #45221

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 1, 2025
@zhagnlu zhagnlu changed the title fix: fix bug for shredding json when empty json but not null Nov 1, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Nov 1, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2025

@zhagnlu Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #")

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Nov 1, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot sre-ci-robot added do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager labels Nov 1, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[WARNING] No dependent PR reference found

  • Target branch '2.6' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2025

@zhagnlu Please associate the related issue to the body of your Pull Request. (eg. "issue: #")

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.95%. Comparing base (cb08db0) to head (df4a373).
⚠️ Report is 179 commits behind head on 2.6.

Files with missing lines Patch % Lines
...nternal/core/src/index/json_stats/JsonKeyStats.cpp 66.66% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6   #45214      +/-   ##
==========================================
- Coverage   76.99%   76.95%   -0.04%     
==========================================
  Files        1700     1831     +131     
  Lines      262533   285880   +23347     
==========================================
+ Hits       202142   220006   +17864     
- Misses      53550    58798    +5248     
- Partials     6841     7076     +235     
Components Coverage Δ
Client 77.99% <66.36%> (-0.15%) ⬇️
Core 84.09% <75.93%> (+1.87%) ⬆️
Go 74.96% <56.59%> (-0.43%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/index/json_stats/JsonKeyStats.h 65.42% <ø> (-2.77%) ⬇️
..._json_stats/test_traverse_json_for_build_stats.cpp 100.00% <100.00%> (ø)
...nternal/core/src/index/json_stats/JsonKeyStats.cpp 86.59% <66.66%> (-0.68%) ⬇️

... and 445 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@mergify mergify bot added the ci-passed label Nov 1, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhagnlu, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[WARNING] No dependent PR reference found

  • Target branch '2.6' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@zhagnlu zhagnlu added this to the 2.6.5 milestone Nov 3, 2025
@sre-ci-robot sre-ci-robot removed the do-not-merge/need-milestone generate by v2-label-manager label Nov 3, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[WARNING] No dependent PR reference found

  • Target branch '2.6' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

Use /refresh-label to update related check and label manually

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Nov 3, 2025

/refresh-label

@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Refresh-Label

  • Title: fix: fix bug for shredding json when empty but not null json
  • Target: 2.6
  • Labels: kind/bug, size/M, approved, ci-passed, dco-passed, do-not-merge/need-merge-master-first

[FAILED] PR #45221 not merged

Use /refresh-label to update related check and label manually

@mergify mergify bot removed the ci-passed label Nov 3, 2025
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Nov 3, 2025

/ci-rerun-ut-integration

Signed-off-by: luzhang <luzhang@zilliz.com>
@zhagnlu zhagnlu force-pushed the fix_empty_json_2.6 branch from a02fafa to df4a373 Compare November 3, 2025 06:39
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[FAILED] PR #45221 not merged

Use /refresh-label to update related check and label manually

@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2025

@zhagnlu cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Nov 3, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.

3 participants